Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-2496 updated sub-domain-suffix requirements #2086

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Nov 20, 2024

Describe your changes (can list changeset entries if preferable)

  • Updated sub-domain-suffix requirements to false, as it's not used by the example app deploys and was causing the workflow to fail.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners November 20, 2024 11:43
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 7753ada

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the ci label Nov 20, 2024
siggerzz
siggerzz previously approved these changes Nov 20, 2024
@siggerzz siggerzz merged commit 9a37ddf into main Nov 20, 2024
28 checks passed
@siggerzz siggerzz deleted the DSW-2496-fix-build-examples branch November 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants