Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-toast): DSW-2476 rtl updates to the component #2082

Merged
merged 19 commits into from
Nov 22, 2024
Merged

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Nov 19, 2024

Describe your changes (can list changeset entries if preferable)

  • Enures the alignment and animation of the component follows the design guidelines for both LTR and RTL. The component should slide from the left for LTR and from the right for RTL.
  • Updates the motion illustration as requested by design.
  • Updates the padding values of the container to match designs as requested in the design review

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.

Reviewer checklists (complete before approving)

Reviewer 1 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: d411235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-toast Minor
pie-storybook Minor
pie-docs Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe marked this pull request as ready for review November 19, 2024 16:37
@raoufswe raoufswe requested review from a team as code owners November 19, 2024 16:37
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-2082 November 19, 2024 16:43 Inactive
@raoufswe raoufswe merged commit 9f666e6 into main Nov 22, 2024
30 checks passed
@raoufswe raoufswe deleted the dsw-2476-toast-rtl branch November 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants