Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-storybook): DSW-2468 Add testing deployment for storybook #2056

Merged
merged 30 commits into from
Nov 20, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Nov 13, 2024

Describe your changes (can list changeset entries if preferable)

  • Added testing storybook deployment
  • Fix Amplify teardown step which has duplicate env section

Note: No tests are currently directed to this test instance.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview

Reviewer checklists (complete before approving)

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners November 13, 2024 09:16
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 8d19744

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

package.json Outdated Show resolved Hide resolved
Co-authored-by: Ben Siggery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants