Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pie-divider): DSW-2277 Divider visual test refactor #2028

Closed
wants to merge 2 commits into from

Conversation

JoshuaNg2332
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

  • Added Divider Visual Test storybook story.
  • Added Divider visual test refactor
  • Added Divider page object and supporting code

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners November 6, 2024 15:34
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: e5f31cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Nov 6, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against e5f31cf

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-2028 November 6, 2024 15:40 Inactive
@JoshuaNg2332 JoshuaNg2332 added work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Nov 6, 2024
@@ -0,0 +1,69 @@
import { html } from 'lit';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, probably worth renaming this to pie-divider.test.stories.ts 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps components DO NOT MERGE pie-divider pie-storybook pie-webc-testing work-in-progress This pull request is still a work in progress and may not be ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants