feat(pie-storybook): DSW-000 add isVisuallyHidden to the assistive text stories #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d417552 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
raoufswe
force-pushed
the
dsw-000-add-missing-prop-assisitve-text
branch
from
b902941
to
d417552
Compare
jamieomaguire
approved these changes
Oct 17, 2024
leksaBoiko
approved these changes
Oct 17, 2024
| @@ -28,6 +28,13 @@ const assistiveTextStoryMeta: AssistiveTextStoryMeta = { | |||
| summary: defaultProps.variant, | |||
| }, | |||
| }, | |||
| isVisuallyHidden: { | |||
| description: 'If true, hides the component visually but leaves it accessible for a11y technologies.', | |||
There was a problem hiding this comment.
Suggested change
| description: 'If true, hides the component visually but leaves it accessible for a11y technologies.', | |
| description: 'If true, hides the component visually but leaves it accessible for screen readers.', |
This might be clearer, or saying 'accessibility' rather than 'ally' just in case it isn't as obvious :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
While working on my radio ticket, I noticed that the
isVisuallyHiddenin the pie-assistive-text component stories wasn't bound / hooked correctly. This PR is to fix that.Author Checklist (complete before requesting a review)
PIE Storybook/PIE DocsPR previewReviewer checklists (complete before approving)
Reviewer 1 - @jamieomaguire
PIE Storybook/PIE DocsPR previewReviewer 2
PIE Storybook/PIE DocsPR preview