Improve Decodable implementation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func makeContext() -> [String: Any] { | ||
| [ | ||
| "name": name, | ||
| "productType": productType.rawValue, |
There was a problem hiding this comment.
Although the keys in the rest of the file use snake casing, I left this one to match the name of the property to avoid breaking backward compatibility with the Stencil file provided as part of the current major version.
akuzminskyi
approved these changes
Aug 30, 2024
Sources/Core/Spec+Context.swift
Outdated
| "package_name": name, | ||
| "platforms": platforms, | ||
| "local_dependencies": localDependencies, | ||
| "remote_dependencies": remoteDependencies.map{ $0.makeContext() }, |
There was a problem hiding this comment.
minor:
Suggested change
| "remote_dependencies": remoteDependencies.map{ $0.makeContext() }, | |
| "remote_dependencies": remoteDependencies.map { $0.makeContext() }, |
tot follow a style that you have
Sources/Models/Spec.swift
Outdated
| self.version = try container.decodeIfPresent(String.self, forKey: .version) | ||
| self.revision = try container.decodeIfPresent(String.self, forKey: .revision) | ||
| self.branch = try container.decodeIfPresent(String.self, forKey: .branch) | ||
| self.ref = (try? Ref(from: decoder)) ?? nil |
There was a problem hiding this comment.
why do we need ?? nil if try? already returns nil(nil ?? nil)
akuzminskyi
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the decoding logic of the models (using Decodable as God intended) addressing the feedback raised by @akuzminskyi in #5 (see my original reply).