Bug fix: Settings Form saves without validation

justcoded · Jul 13, 2019 · cf0b511 · cf0b511
1 parent db2a779
commit cf0b511
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 CHANGELOG
 =====================
 
+v1.0.1
+---------------------
+* Bug fix: Settings Form saves without validation
+
 v1.0
 ---------------------
 * Component, DbComponent, Interface

diff --git a/src/forms/SettingsForm.php b/src/forms/SettingsForm.php
@@ -53,6 +53,10 @@ public function loadData()
 	 */
 	public function save()
 	{
+		if (! $this->validate()) {
+			return false;
+		}
+
 		$save = true;
 		foreach ($this->getAttributes() as $key => $value) {
 			$save &= Instance::of(SettingsInterface::class)->get()->set($this->sectionName(), $key, $value);