Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added description and comment columns in all existing tables and apis #284

Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: added description and comment columns in all existing tables and apis #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions crates/context_aware_config/src/api/config/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,31 @@ fn construct_new_payload(
},
)?;

return Ok(web::Json(PutReq {
context: context,
let description = match res.get("description") {
Some(Value::String(s)) => Some(s.clone()),
Some(_) => {
log::error!("construct new payload: Description is not a valid string");
return Err(bad_argument!("Description must be a string"));
}
None => None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sauraww construct_new_payload function is used by reduce, I don't know if we can just get the description like this. I think we'll need to combine all the descriptions being reduced into one or

insert a new description

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting that we take it as input in the reduce api itself ?

};

// Handle change_reason
let change_reason = res
.get("change_reason")
.and_then(|val| val.as_str())
.map(|s| s.to_string())
.ok_or_else(|| {
log::error!("construct new payload: Change reason not present or invalid");
bad_argument!("Change reason is required and must be a string")
})?;
Comment on lines +383 to +400
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have different processing flows for the same kind of data?


Ok(web::Json(PutReq {
context,
r#override: override_,
}));
description,
change_reason,
}))
}

#[allow(clippy::too_many_arguments)]
Expand Down
Loading
Loading