postgres: always create socketDir during init if not already present
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the socketDir is in tmpfs, or if it is deleted by some other process, we would want the socketDir to be created, if not already present, on restarts.
shivaraj-bh
added a commit
to nammayatri/nammayatri
that referenced
this pull request
Jan 31, 2024
postgres-init process will now create socketDir if it is not already present. This is important for `replica` process because it doesn't create the datadir, it is created by `pg-basebackup` process. This was fixed in services-flake, here: juspay/services-flake#88
hkmangla
pushed a commit
to nammayatri/nammayatri
that referenced
this pull request
Jan 31, 2024
postgres-init process will now create socketDir if it is not already present. This is important for `replica` process because it doesn't create the datadir, it is created by `pg-basebackup` process. This was fixed in services-flake, here: juspay/services-flake#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the socketDir is in
tmpfs, or if it is deleted by some other process, we would want thesocketDirto be created, if not already present, on restarts.