Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres ensure socketDir mktemp init succeeds #81

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Jan 18, 2024

@shivaraj-bh
Copy link
Member

Can we also add a test for the scenario where socketDir is different from dataDir? pg2 in nix/postgres/postgres_test can be used for this maybe? even pg1 works. Should’ve done this in the last PR perhaps, would’ve been caught in CI.

@johnalotoski
Copy link
Contributor Author

Good idea, I can look at doing that tomorrow.

@johnalotoski
Copy link
Contributor Author

Added the test @shivaraj-bh.

@shivaraj-bh
Copy link
Member

Great!

Just to confirm I ran the test with the current main, and as expected it does fail:
Screenshot 2024-01-20 at 12 18 08 AM

Looks good

@shivaraj-bh shivaraj-bh merged commit eb8361b into juspay:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants