Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Postgres]: Fix test process not starting #78

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Jan 17, 2024

On the first run, when data directory doesn’t exist, both the init processes (pg1-init and pg2-init) will try to create the data directory and one of them fails, leading to one of the server not starting. To solve this, pg2-init can depend on pg1-init completing.

Also depends_on option added to postgres here, will not be needed because we can do it as demonstrated in example/flake.nix and nix/postgres/postgres_test.nix (check the diff). This keeps the definition of depends_on in one-place.

Resolves #74

@shivaraj-bh shivaraj-bh merged commit bf3a582 into main Jan 18, 2024
2 checks passed
@shivaraj-bh shivaraj-bh deleted the pg-init-depends-on branch January 18, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI hangs infinitely
1 participant