Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/tika: init #269

Merged
merged 2 commits into from
Jul 15, 2024
Merged

service/tika: init #269

merged 2 commits into from
Jul 15, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 12, 2024

Tika has been merged today (NixOS/nixpkgs#279059) so we need to wait 2~3 days until it become available here.

Once there, I'll set this PR in Ready for review.

@drupol drupol marked this pull request as ready for review July 14, 2024 19:26
@shivaraj-bh
Copy link
Member

I am also planning to work on a script that will initialise all the files required to add a new service, but for now could you also add a docs/tika.md file with a brief description for tika and a Getting started block with services.tika.enable = true;?

Further improvement on the docs can be done in a different PR upon coming up with use cases for using it with other services (I still have to update searxng docs as well, to use it with open-webui, I will do that soon)

Copy link
Member

@shivaraj-bh shivaraj-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only two things remaining:

  1. Add a docs/tika.md file
  2. Rewrite the commit messages to:
  • feat(tika): init
  • chore(searxng): use http_get

2 is because we use conventional commits to help during releases.

@drupol
Copy link
Contributor Author

drupol commented Jul 15, 2024

Done, should be good now.

@shivaraj-bh shivaraj-bh merged commit f041f87 into juspay:main Jul 15, 2024
2 checks passed
@shivaraj-bh
Copy link
Member

Thanks!

@drupol drupol deleted the module/add-tika branch July 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants