Improve speed of tests #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other platforms need not unnecessarily build these packages
|
We can improve the build time by disabling check for grafana instead. |
I tried that, it was still taking a while to build locally. These broken packages should be a temp issue, so I'd say let's just use older nixpkgs until they fix it upstream. We benefit from official cache. |
|
Also less code is generally better. We don't want to maintain our own $package derivations. That's nixpkgs' job. |
srid
commented
Mar 7, 2024
|
|
||
| # grafana is broken on aarch64-darwin, but works on older nixpkgs: | ||
| # https://github.com/NixOS/nixpkgs/issues/273998 | ||
| grafana = (builtins.getFlake "github:nixos/nixpkgs/b604023e0a5549b65da3040a07d2beb29ac9fc63").legacyPackages.${system}.grafana; |
There was a problem hiding this comment.
Just one line: we don't even have to add an extra flake input.
|
Okay, I will fix it upstream then. |
This speeds up build, because we no longer have to compile grafana locally and wait for eternity. cf. NixOS/nixpkgs#273998
We don't need per-file package overlays, since we don't envision having too many of them. Whenever possible, get them from nixpkgs, to keep our tests nimble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
nixcion my mac is extremely slow mainly due to grafana build. The slowness also translates to all of CI platforms.Tests should run swiftly as possible. Our project is not complicated. If something's fucked in nixpkgs, we shouldn't have to get hit by slow build times.