Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: test regression #109

Merged
merged 3 commits into from
Feb 27, 2024
Merged

clickhouse: test regression #109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c64f1de
maybe it is the readiness_probe?
shivaraj-bh Feb 21, 2024
29efe89
Merge branch 'main' into clickhouse-test-regression
shivaraj-bh Feb 27, 2024
6849689
add fixme for clickhouse-client readiness_probe
shivaraj-bh Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion nix/clickhouse/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,13 @@ in
command = "${lib.getExe startScript}";

readiness_probe = {
exec.command = ''${config.package}/bin/clickhouse-client --query "SELECT 1" --port ${builtins.toString config.port}'';
# FIXME: revert back to clickhouse-client readiness_probe once CI is moved out of github public runners
# See: https://github.com/juspay/services-flake/issues/100
# exec.command = ''${config.package}/bin/clickhouse-client --query "SELECT 1" --port ${builtins.toString config.port}'';
http_get = {
host = "localhost";
port = if (lib.hasAttr "http_port" config.extraConfig) then config.extraConfig.http_port else 8123;
};
initial_delay_seconds = 2;
period_seconds = 10;
timeout_seconds = 4;
Expand Down
Loading