Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: just cargo-test was erroneously running cargo doc #356

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Dec 2, 2024

Also fixes tests failing due to deprecation of nixci and nix-health flake configs. See

- `nix-health` and `nixci` flake output configurations are no longer supported.

Notes on changes:

  • test_services_flake doesn’t run om ci on all the sub-flakes (which was the case before) because unlike before we have a lot of services and since the goal of the test is to just check if the stdout is not polluted with non-outPaths, testing a smaller sub-flake should suffice.
  • test_config_loading upgrades the commit of haskell-flake to the one that uses om.ci configuration.

@shivaraj-bh
Copy link
Member Author

https://github.com/juspay/omnix/actions/runs/12117052416/job/33778697244?pr=356
Confirmed that the tests are now running in CI

image

@srid srid merged commit 6fc4819 into main Dec 2, 2024
5 checks passed
@srid srid deleted the fix-justfile branch December 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants