fix(ci): abrupt exit upon ci failure #6891
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
|
Review changes with |
pixincreate
changed the title
|
this is not a priority. i'll mark it as draft for now until root cause of abrupt fail is detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When CI checks are run in parallel, it would result in abrupt exit when one of the connector failed. This PR aims to fix that.
closes #6890
Additional Changes
Motivation and Context
Parallel CI needed this fix for so long.
How did you test it?
This cannot be tested without running CI checks in parallel which is bound to fail due to resource constraints.
The issue cannot be reproduced in local at all.
This change shouldn't cause any abrupt exits going forward.
Checklist
cargo +nightly fmt --allcargo clippy