-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Deutschebank] Implement Card 3ds #6844
Open
Debarshi-Gupta
wants to merge
14
commits into
main
Choose a base branch
from
deutsche_bank_card_3ds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+979
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files |
2 tasks
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
AkshayaFoiger
previously approved these changes
Dec 19, 2024
deepanshu-iiitu
requested changes
Dec 19, 2024
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
requested changes
Dec 19, 2024
crates/router/src/configs/defaults/payment_connector_required_fields.rs
Outdated
Show resolved
Hide resolved
crates/router/src/configs/defaults/payment_connector_required_fields.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
approved these changes
Dec 20, 2024
Chethan-rao
approved these changes
Dec 20, 2024
AkshayaFoiger
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implement Card 3ds for Deutschebank
Additional Changes
Motivation and Context
https://testmerch.directpos.de/rest-api/apidoc/v2.1/index.html#creditCard3DSecureInitializingThePaymentSsteps1_4
How did you test it?
Cypress Tests
1. No3DSManualCapture
2. 3DSAutoCapture
3. 3DSManualCapture
4. No3DSAutoCapture
5. VoidPayment
6. SyncPayment
7. RefundPayment
8. SyncRefund
Note: Currently, no 3ds for card payments are not being supported for Deutschebank. Hence, no 3ds flows are expected to return an error message saying that the payment method type is not supported, and has been handled in the cypress tests accordingly.
Postman Tests
1. Authorize (Manual)
2. Capture (Manual)
3. Authorize + Capture
4. PSync
5. Refund
6. RSync
7. Cancel/Void
Checklist
cargo +nightly fmt --all
cargo clippy