Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payments): [Payment links] Add support for traditional chinese locale #6762

Closed
wants to merge 1 commit into from
Closed

feat(payments): [Payment links] Add support for traditional chinese locale #6762

wants to merge 1 commit into from

Conversation

cookieg13
Copy link
Contributor

@cookieg13 cookieg13 commented Dec 6, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

hotfix for #6745

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@cookieg13 cookieg13 requested a review from a team as a code owner December 6, 2024 05:43
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 6, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payment_link/locale.js  6% smaller

@cookieg13 cookieg13 self-assigned this Dec 6, 2024
sahkal
sahkal previously approved these changes Dec 6, 2024
View reviewed changes
@cookieg13 cookieg13 linked an issue Dec 6, 2024 that may be closed by this pull request
[FEATURE] Add support for traditional chinese locale for payment links #6746
Open
2 tasks
@cookieg13 cookieg13 changed the title feat(payments): [Payment links] Add support for traditional chinese l… feat(payments): [Payment links] Add support for traditional chinese locale for payment links Dec 6, 2024
@cookieg13 cookieg13 changed the title feat(payments): [Payment links] Add support for traditional chinese locale for payment links feat(payments): [Payment links] Add support for traditional chinese locale for payment links Dec 6, 2024
srujanchikke
srujanchikke previously approved these changes Dec 6, 2024
View reviewed changes
@cookieg13 cookieg13 changed the base branch from hotfix-2024.12.05.0 to hotfix-2024.12.04.0 December 6, 2024 08:07
@cookieg13 cookieg13 dismissed stale reviews from srujanchikke and sahkal December 6, 2024 08:07

The base branch was changed.

@cookieg13 cookieg13 requested review from a team as code owners December 6, 2024 08:07
@cookieg13 cookieg13 changed the base branch from hotfix-2024.12.04.0 to hotfix-2024.12.05.0 December 6, 2024 08:07
@cookieg13 cookieg13 changed the title feat(payments): [Payment links] Add support for traditional chinese locale for payment links feat(payments): [Payment links] Add support for traditional chinese locale for payment l Dec 6, 2024
@cookieg13 cookieg13 changed the title feat(payments): [Payment links] Add support for traditional chinese locale for payment l feat(payments): [Payment links] Add support for traditional chinese locale Dec 6, 2024
@cookieg13 cookieg13 closed this Dec 9, 2024
@SanchithHegde SanchithHegde deleted the addTraditionalChineseLocaleHotfix branch December 15, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke left review comments

@sahkal sahkal sahkal left review comments

Assignees

@cookieg13 cookieg13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for traditional chinese locale for payment links
3 participants
@cookieg13 @sahkal @srujanchikke