Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): diesel models, domain models and db interface changes for callback_mapper table #6571
base: main
Are you sure you want to change the base?
feat(core): diesel models, domain models and db interface changes for callback_mapper table #6571
Changes from 4 commits
c774c2a
c41e062
e3ed4a7
9b1056b
0c4ef49
baf137e
df0e757
c5b7164
75d929b
14d20cd
00545fd
38ba137
d7883e6
a520ad9
92ea722
401a44b
89d675b
90ea3bd
60d19e0
946bac6
890373e
610b416
ea91e56
1fb183f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What values are stored in the
id
column: are we generating them or is it being provided from third-party sources?id
field?What sort of values does the
type
column hold, can they be an enum on the Rust side while being aVARCHAR
on the database side?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the defaults on the database side, have the application provide the values for these columns always. This would help prevent issues with the timestamps being generated based on the database server's time zone configuration.