feat(cypress): add test case for incorrect and empty card types #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
14 tasks
2 tasks
Gnanasundari24
previously approved these changes
Nov 19, 2024
pixincreate
reviewed
Nov 19, 2024
kashif-m
requested review from
likhinbopanna,
pixincreate and
Gnanasundari24
pixincreate
reviewed
Dec 13, 2024
Comment on lines
+101
to
+113
| const billingAddress = { | ||
| address: { | ||
| line1: "1467", | ||
| line2: "Harrison Street", | ||
| line3: "Harrison Street", | ||
| city: "San Fransico", | ||
| state: "California", | ||
| zip: "94122", | ||
| country: "BR", | ||
| first_name: "john", | ||
| last_name: "doe", | ||
| }, | ||
| }; |
There was a problem hiding this comment.
if this is specific to a connector or a payment method, then i would recommend having country field empty and override it in respective fields wherever it is used.
also, if i'm not asking too much, can you please also apply the same changes to rest of the file where ever billing exist and is not null.
that way, we can do something like:
billing: {
...billingAddress,
country: DE / GB / BR / IN / US
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Test cases for #6512
Additional Changes
Motivation and Context
Adds test cases for card types.
How did you test it?
Locally.
Checklist
cargo +nightly fmt --allcargo clippy