fix(webhooks): add support for updating mandate details in webhooks flow #6523

srujanchikke · 2024-11-10T19:34:25Z

Type of Change

Description

For Fiuu, the mandate ID is updated via webhooks in the case of 3DS payments. The payment webhook body was not consumed when the payment was successful, causing intermittent issues in the sandbox environment. This PR adds support to address this issue.

more detailed issue description :

Fiuu mandate id is consumed from webhooks
Incase of 3ds payment, on returning to hs return url we do a psync call
If psync happends before we get notification from connector, we don't consume the webhook. Hence we will never have connector mandate id in our system.
To consume the webhook, we can add logic in webhooks core that after psync check for the source verification & webhook event based on that get mandate details from webhook and update it in the payment method & payment attempt.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cannot be tested directly this is an intermediate issue in sandbox. So please test this flow multiple time and mandate id should be stored in CIT transaction against both payment attempt & payment method for the transaction.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-11-10T19:34:27Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/fiuu/transformers.rs	25% smaller
crates/router/src/core/webhooks/incoming.rs	5% smaller
crates/diesel_models/src/payment_attempt.rs	2% smaller
crates/hyperswitch_connectors/src/connectors/fiuu.rs	1% smaller
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs	0% smaller
crates/hyperswitch_domain_models/src/router_flow_types/webhooks.rs	0% smaller
crates/hyperswitch_interfaces/src/webhooks.rs	0% smaller
crates/router/src/configs/defaults/payment_connector_required_fields.rs	0% smaller
crates/router/src/services/connector_integration_interface.rs	Unsupported file format

sai-harsha-vardhan · 2024-11-11T09:53:10Z

crates/api_models/src/webhooks.rs

@@ -246,3 +246,8 @@ pub struct ConnectorWebhookSecrets {
    pub secret: Vec<u8>,
    pub additional_secret: Option<masking::Secret<String>>,
 }
+
+#[derive(Debug, Clone, Serialize)]
+pub struct ConnectorMandateDetails {


Please move this to domain models

sai-harsha-vardhan · 2024-11-11T10:01:21Z

crates/hyperswitch_connectors/src/connectors/fiuu.rs

+            request
+                .body
+                .parse_struct("fiuu::FiuuWebhooksResponse")
+                .change_context(errors::ConnectorError::WebhookResourceObjectNotFound)?


Suggested change

.change_context(errors::ConnectorError::WebhookResourceObjectNotFound)?

.change_context(errors::ConnectorError::WebhookBodyDecodingFailed)?

sai-harsha-vardhan · 2024-11-11T10:05:46Z

crates/hyperswitch_connectors/src/connectors/fiuu.rs

+                .change_context(errors::ConnectorError::WebhookResourceObjectNotFound)?
+        };
+        match payload.clone() {
+            FiuuWebhooksResponse::FiuuWebhookPaymentResponse(webhook_payment_response) => {


We can directly parse it into FiuuWebhookPaymentResponse

sai-harsha-vardhan · 2024-11-11T10:22:22Z

crates/router/src/core/webhooks/incoming.rs

+                .await
+                .to_not_found_response(errors::ApiErrorResponse::PaymentMethodNotFound)?;
+
+            if payment_method_info.connector_mandate_details.is_none() {


is_none won't work here, we should check the existence of mca_id in the hashmap

…low (#6523) Co-authored-by: Chikke Srujan <[email protected]> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>

add support for consuming webhooks mandate id

a5db2af

srujanchikke added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 10, 2024

srujanchikke self-assigned this Nov 10, 2024

srujanchikke requested review from a team as code owners November 10, 2024 19:34

srujanchikke added A-connector-integration Area: Connector integration A-core Area: Core flows A-webhooks Area: Webhook flows labels Nov 10, 2024

hyperswitch-bot bot and others added 3 commits November 10, 2024 19:35

chore: run formatter

4483080

clippy fix

0236d92

resolve comments

73e41bd

srujanchikke requested a review from sai-harsha-vardhan November 11, 2024 07:50

chore: run formatter

1dcabec

AkshayaFoiger previously approved these changes Nov 11, 2024

View reviewed changes

minor fix

d586010

srujanchikke dismissed AkshayaFoiger’s stale review via d586010 November 11, 2024 08:19

Chikke Srujan and others added 5 commits November 11, 2024 13:51

revert comments

b778ae4

fix helper.rs

32c44e7

add loggers

8fb5347

chore: run formatter

9146edb

Merge branch 'main' into webhook_fix

6f25eb8

sai-harsha-vardhan reviewed Nov 11, 2024

View reviewed changes

resolve comments

efe9117

srujanchikke force-pushed the webhook_fix branch from 37a5774 to efe9117 Compare November 12, 2024 14:34

hyperswitch-bot bot and others added 2 commits November 12, 2024 14:35

chore: run formatter

cac8d1d

revert few changes

465aea0

jarnura previously approved these changes Nov 12, 2024

View reviewed changes

sai-harsha-vardhan previously approved these changes Nov 12, 2024

View reviewed changes

minor fix

f239f59

srujanchikke dismissed stale reviews from sai-harsha-vardhan and jarnura via f239f59 November 12, 2024 16:49

chore: run formatter

c4d1714

jarnura approved these changes Nov 13, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Nov 13, 2024

View reviewed changes

AkshayaFoiger approved these changes Nov 13, 2024

View reviewed changes

deepanshu-iiitu approved these changes Nov 13, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Nov 13, 2024

Merged via the queue into main with commit 6eb72e9 Nov 13, 2024
15 of 17 checks passed

Gnanasundari24 deleted the webhook_fix branch November 13, 2024 10:20

srujanchikke mentioned this pull request Nov 13, 2024

fix(webhooks): add support for updating mandate details in webhooks flow #6558

Merged

14 tasks

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(webhooks): add support for updating mandate details in webhooks flow #6523

fix(webhooks): add support for updating mandate details in webhooks flow #6523

srujanchikke commented Nov 10, 2024 •

edited

Loading

semanticdiff-com bot commented Nov 10, 2024 •

edited

Loading

sai-harsha-vardhan Nov 11, 2024

sai-harsha-vardhan Nov 11, 2024

sai-harsha-vardhan Nov 11, 2024

sai-harsha-vardhan Nov 11, 2024

	.change_context(errors::ConnectorError::WebhookResourceObjectNotFound)?
	.change_context(errors::ConnectorError::WebhookBodyDecodingFailed)?

fix(webhooks): add support for updating mandate details in webhooks flow #6523

fix(webhooks): add support for updating mandate details in webhooks flow #6523

Conversation

srujanchikke commented Nov 10, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Nov 10, 2024 • edited Loading

sai-harsha-vardhan Nov 11, 2024

Choose a reason for hiding this comment

sai-harsha-vardhan Nov 11, 2024

Choose a reason for hiding this comment

sai-harsha-vardhan Nov 11, 2024

Choose a reason for hiding this comment

sai-harsha-vardhan Nov 11, 2024

Choose a reason for hiding this comment

srujanchikke commented Nov 10, 2024 •

edited

Loading

semanticdiff-com bot commented Nov 10, 2024 •

edited

Loading