Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analytics): add setup instructions for currency_conversion service #6516

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

maverox
Copy link
Contributor

@maverox maverox commented Nov 8, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Now that analytics depends on currency_conversion crate after this PR, we need to include instructions in analytics documentation to set up this service.

Fixes #6513

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This is related to the PR #6418 and documents the necessary prerequisite setup info.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@maverox maverox requested a review from a team as a code owner November 8, 2024 08:27
Copy link

Review changes with  SemanticDiff

@maverox maverox self-assigned this Nov 8, 2024
@maverox maverox added C-doc Category: Documentation updates A-Analytics labels Nov 8, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 31a38db Nov 13, 2024
22 of 25 checks passed
@likhinbopanna likhinbopanna deleted the doc-update branch November 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analytics C-doc Category: Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(analytics): Instructions to set up currency_conversion (third party dependency API)
5 participants