ci(cypressV2): update cypress v2 framework to accommodate hyperswitch v2 changes #6493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
|
Review changes with Changed Files
|
0001 contains an example for payment intent create call, confirm call and retrieve call. and of course, these does not work at present and hence, skipped intentionally from being run. add more number contexts within describe to address all the cases mentioned at the top of the file. configs needs to be introduced. but before that, we need to do some structural changes to change the behavior
…firm and retrieve intents CC: Narayan Bhat <[email protected]>
pixincreate
changed the title
pixincreate
changed the title
likhinbopanna
previously approved these changes
Nov 7, 2024
Sakilmostak
approved these changes
Nov 8, 2024
likhinbopanna
approved these changes
Nov 8, 2024
pixincreate
removed
the
S-waiting-on-review
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces multiple fixes for Cypress V2 at framework level. The fixes include:
undefinedinstead of valid error message. This commit fixes thatkey_idvalidations to a separate function to reduce duplicate code. Refer here and hereisoTimeTomorrowto RequestBodyUtilsImportant
It is recommended that the PR is reviewed based on commits instead of going through the file at a time
Payment tests have not been added, but only template example just to serve as a reference for devs working on v2 to fill in.
Additional Changes
Motivation and Context
I'm the motivation.
How did you test it?
Ran Cypress V2 tests against Hyperswitch V2
Checklist
prettier . --writecargo clippy