Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): worldpay - add dynamic fields and update terminal status mapping #6468

Merged
merged 14 commits into from
Nov 28, 2024
Merged

feat(connector): worldpay - add dynamic fields and update terminal status mapping #6468

merged 14 commits into from
Nov 28, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Oct 30, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR contains changes to

  • update status mapping for Worldpay - payments and refunds
  • add required fields for Worldpay
  • fix refund retrieve bug for Worldpay

Described in detail - #6316 point # 5

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Keeps the behavior of CaptureMethod uniform across connectors
  • Introduces default fields for Worldpay cards

How did you test it?

  • Run Worldpay's cypress test cases
Screenshot 2024-11-27 at 4 15 21 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 30, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/commands.js  79% smaller
  crates/storage_impl/src/payments/payment_attempt.rs  62% smaller
  crates/router/src/configs/defaults/payment_connector_required_fields.rs  43% smaller
  crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs  22% smaller
  crates/diesel_models/src/query/payment_attempt.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/worldpay.rs  0% smaller
  crates/hyperswitch_domain_models/src/payments/payment_attempt.rs  0% smaller
  crates/router/src/core/refunds.rs  0% smaller
  crates/router/src/db/kafka_store.rs  0% smaller
  crates/storage_impl/src/mock_db/payment_attempt.rs  0% smaller
  cypress-tests/cypress/e2e/PaymentUtils/WorldPay.js  0% smaller
  cypress-tests/cypress/fixtures/confirm-body.json  0% smaller
  cypress-tests/cypress/fixtures/create-confirm-body.json  0% smaller
  cypress-tests/cypress/fixtures/create-mandate-cit.json  0% smaller
  cypress-tests/cypress/fixtures/create-mandate-mit.json  0% smaller
  cypress-tests/cypress/fixtures/create-pm-id-mit.json  0% smaller
  cypress-tests/cypress/fixtures/save-card-confirm-body.json  0% smaller

@kashif-m kashif-m self-assigned this Oct 30, 2024
@kashif-m kashif-m linked an issue Oct 30, 2024 that may be closed by this pull request
[REFACTOR] Worldpay payments integration #6316
Open
2 tasks
@kashif-m kashif-m mentioned this pull request Nov 25, 2024
Open
2 tasks
@kashif-m kashif-m marked this pull request as ready for review November 25, 2024 10:03
@kashif-m kashif-m requested a review from a team as a code owner November 25, 2024 10:03
@kashif-m kashif-m changed the title feat(connector): [worldpay] use auto-capture by default and add dynamic fields feat(connector): worldpay - add dynamic fields and update terminal status mapping Nov 26, 2024
@kashif-m kashif-m requested review from a team as code owners November 26, 2024 10:22
@likhinbopanna
Copy link
Contributor

Also, Run the Worldpay cypress test cases ?

jarnura
jarnura requested changes Nov 26, 2024
View reviewed changes
crates/router/src/core/refunds.rs Outdated Show resolved Hide resolved
crates/router/src/core/refunds.rs Outdated Show resolved Hide resolved
srujanchikke
srujanchikke previously approved these changes Nov 26, 2024
View reviewed changes
pixincreate
pixincreate previously approved these changes Nov 26, 2024
View reviewed changes
@kashif-m
refactor(core): use ConnectorTransactionId for find_payment_attempt_b…
9b7828e 
…y_connector_transaction_id_payment_id_merchant_id query
@kashif-m kashif-m dismissed stale reviews from pixincreate and srujanchikke via 9b7828e November 26, 2024 15:54
@kashif-m kashif-m requested a review from a team as a code owner November 26, 2024 15:54
jarnura
jarnura previously approved these changes Nov 27, 2024
View reviewed changes
pixincreate
pixincreate previously approved these changes Nov 27, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 5a98ed6 Nov 28, 2024
15 of 17 checks passed
@likhinbopanna likhinbopanna deleted the worldpay-defaults branch November 28, 2024 14:50
pixincreate added a commit that referenced this pull request Nov 28, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into multiple-cr…
9878b6f 
…ed-cypress

* 'main' of github.com:juspay/hyperswitch:
  feat(connector): worldpay - add dynamic fields and update terminal status mapping (#6468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhinbopanna likhinbopanna likhinbopanna left review comments

@pixincreate pixincreate pixincreate approved these changes

@jarnura jarnura jarnura approved these changes

@srujanchikke srujanchikke srujanchikke left review comments

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu left review comments

Assignees

@kashif-m kashif-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Worldpay payments integration
6 participants
@kashif-m @likhinbopanna @jarnura @deepanshu-iiitu @pixincreate @srujanchikke