-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): [Novalnet] Add mandatory fields for wallets and card in config #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
cookieg13
changed the title
Add mandatory fields for googlepay, paypal and applepay
fix(connector): [Novalnet] Add mandatory fields for wallets and card in config
Oct 29, 2024
cookieg13
force-pushed
the
defaultFixesForNovalnet
branch
from
November 4, 2024 08:07
2c1182b
to
021cd3a
Compare
cookieg13
force-pushed
the
defaultFixesForNovalnet
branch
2 times, most recently
from
November 4, 2024 08:30
6d84e80
to
f4be25e
Compare
cookieg13
force-pushed
the
defaultFixesForNovalnet
branch
2 times, most recently
from
November 5, 2024 12:25
df3d19d
to
f1d15e4
Compare
srujanchikke
reviewed
Nov 5, 2024
"billing.address.line2".to_string(), | ||
RequiredFieldInfo { | ||
required_field: "payment_method_data.billing.address.line2".to_string(), | ||
display_name: "line1".to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
display_name: "line1".to_string(), | |
display_name: "line2".to_string(), |
can we change it at all other places?
cookieg13
force-pushed
the
defaultFixesForNovalnet
branch
from
November 6, 2024 07:07
f1d15e4
to
4f8b3e0
Compare
srujanchikke
approved these changes
Nov 6, 2024
deepanshu-iiitu
approved these changes
Nov 6, 2024
@cookieg13 Please raise the another PR regarding cypress changes |
14 tasks
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
Fix to this issue https://github.com/juspay/hyperswitch-cloud/issues/7291
How did you test it?
Manually tested with postman
Payment Methods Response
{ "redirect_url": "https://google.com/success", "currency": "EUR", "payment_methods": [ { "payment_method": "wallet", "payment_method_types": [ { "payment_method_type": "apple_pay", "payment_experience": [ { "payment_experience_type": "redirect_to_url", "eligible_connectors": [ "novalnet" ] } ], "card_networks": null, "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "billing.address.zip": { "required_field": "payment_method_data.billing.address.zip", "display_name": "zip", "field_type": "user_address_pincode", "value": "12345" }, "billing.address.line1": { "required_field": "payment_method_data.billing.address.line1", "display_name": "line1", "field_type": "user_address_line1", "value": "1467" }, "billing.email": { "required_field": "payment_method_data.billing.email", "display_name": "email_address", "field_type": "user_email_address", "value": "[email protected]" }, "billing.address.country": { "required_field": "payment_method_data.billing.address.country", "display_name": "country", "field_type": { "user_address_country": { "options": [ "ALL" ] } }, "value": "DE" }, "billing.address.first_name": { "required_field": "payment_method_data.billing.address.first_name", "display_name": "first_name", "field_type": "user_full_name", "value": "Max" }, "browser_info.language": { "required_field": "browser_info.language", "display_name": "browser_info_language", "field_type": "browser_language", "value": null }, "browser_info.ip_address": { "required_field": "browser_info.ip_address", "display_name": "browser_info_ip_address", "field_type": "browser_ip", "value": null }, "billing.address.line2": { "required_field": "payment_method_data.billing.address.line2", "display_name": "line1", "field_type": "user_address_line2", "value": "CA" }, "billing.address.last_name": { "required_field": "payment_method_data.billing.address.last_name", "display_name": "last_name", "field_type": "user_full_name", "value": "Mustermann" }, "billing.address.city": { "required_field": "payment_method_data.billing.address.city", "display_name": "city", "field_type": "user_address_city", "value": "Musterhausen" } }, "surcharge_details": null, "pm_auth_connector": null }, { "payment_method_type": "google_pay", "payment_experience": [ { "payment_experience_type": "redirect_to_url", "eligible_connectors": [ "novalnet" ] } ], "card_networks": null, "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "billing.address.first_name": { "required_field": "payment_method_data.billing.address.first_name", "display_name": "first_name", "field_type": "user_full_name", "value": "Max" }, "browser_info.ip_address": { "required_field": "browser_info.ip_address", "display_name": "browser_info_ip_address", "field_type": "browser_ip", "value": null }, "billing.address.line2": { "required_field": "payment_method_data.billing.address.line2", "display_name": "line1", "field_type": "user_address_line2", "value": "CA" }, "billing.address.last_name": { "required_field": "payment_method_data.billing.address.last_name", "display_name": "last_name", "field_type": "user_full_name", "value": "Mustermann" }, "billing.email": { "required_field": "payment_method_data.billing.email", "display_name": "email_address", "field_type": "user_email_address", "value": "[email protected]" }, "browser_info.language": { "required_field": "browser_info.language", "display_name": "browser_info_language", "field_type": "browser_language", "value": null }, "billing.address.country": { "required_field": "payment_method_data.billing.address.country", "display_name": "country", "field_type": { "user_address_country": { "options": [ "ALL" ] } }, "value": "DE" }, "billing.address.city": { "required_field": "payment_method_data.billing.address.city", "display_name": "city", "field_type": "user_address_city", "value": "Musterhausen" }, "billing.address.zip": { "required_field": "payment_method_data.billing.address.zip", "display_name": "zip", "field_type": "user_address_pincode", "value": "12345" }, "billing.address.line1": { "required_field": "payment_method_data.billing.address.line1", "display_name": "line1", "field_type": "user_address_line1", "value": "1467" } }, "surcharge_details": null, "pm_auth_connector": null }, { "payment_method_type": "paypal", "payment_experience": [ { "payment_experience_type": "redirect_to_url", "eligible_connectors": [ "novalnet" ] } ], "card_networks": null, "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "billing.address.first_name": { "required_field": "payment_method_data.billing.address.first_name", "display_name": "first_name", "field_type": "user_full_name", "value": "Max" }, "billing.address.line2": { "required_field": "payment_method_data.billing.address.line2", "display_name": "line1", "field_type": "user_address_line2", "value": "CA" }, "billing.address.city": { "required_field": "payment_method_data.billing.address.city", "display_name": "city", "field_type": "user_address_city", "value": "Musterhausen" }, "billing.address.last_name": { "required_field": "payment_method_data.billing.address.last_name", "display_name": "last_name", "field_type": "user_full_name", "value": "Mustermann" }, "browser_info.ip_address": { "required_field": "browser_info.ip_address", "display_name": "browser_info_ip_address", "field_type": "browser_ip", "value": null }, "billing.address.line1": { "required_field": "payment_method_data.billing.address.line1", "display_name": "line1", "field_type": "user_address_line1", "value": "1467" }, "billing.address.zip": { "required_field": "payment_method_data.billing.address.zip", "display_name": "zip", "field_type": "user_address_pincode", "value": "12345" }, "billing.email": { "required_field": "payment_method_data.billing.email", "display_name": "email_address", "field_type": "user_email_address", "value": "[email protected]" }, "billing.address.country": { "required_field": "payment_method_data.billing.address.country", "display_name": "country", "field_type": { "user_address_country": { "options": [ "ALL" ] } }, "value": "DE" }, "browser_info.language": { "required_field": "browser_info.language", "display_name": "browser_info_language", "field_type": "browser_language", "value": null } }, "surcharge_details": null, "pm_auth_connector": null } ] }, { "payment_method": "card", "payment_method_types": [ { "payment_method_type": "credit", "payment_experience": null, "card_networks": [ { "card_network": "Mastercard", "surcharge_details": null, "eligible_connectors": [ "novalnet" ] }, { "card_network": "Visa", "surcharge_details": null, "eligible_connectors": [ "novalnet" ] } ], "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "billing.address.first_name": { "required_field": "payment_method_data.billing.address.first_name", "display_name": "first_name", "field_type": "user_full_name", "value": "Max" }, "billing.address.line2": { "required_field": "payment_method_data.billing.address.line2", "display_name": "line1", "field_type": "user_address_line2", "value": "CA" }, "billing.address.city": { "required_field": "payment_method_data.billing.address.city", "display_name": "city", "field_type": "user_address_city", "value": "Musterhausen" }, "billing.address.line1": { "required_field": "payment_method_data.billing.address.line1", "display_name": "line1", "field_type": "user_address_line1", "value": "1467" }, "billing.address.last_name": { "required_field": "payment_method_data.billing.address.last_name", "display_name": "last_name", "field_type": "user_full_name", "value": "Mustermann" }, "billing.address.zip": { "required_field": "payment_method_data.billing.address.zip", "display_name": "zip", "field_type": "user_address_pincode", "value": "12345" }, "billing.email": { "required_field": "payment_method_data.billing.email", "display_name": "email_address", "field_type": "user_email_address", "value": "[email protected]" }, "browser_info.ip_address": { "required_field": "browser_info.ip_address", "display_name": "browser_info_ip_address", "field_type": "browser_ip", "value": null }, "browser_info.language": { "required_field": "browser_info.language", "display_name": "browser_info_language", "field_type": "browser_language", "value": null }, "billing.address.country": { "required_field": "payment_method_data.billing.address.country", "display_name": "country", "field_type": { "user_address_country": { "options": [ "ALL" ] } }, "value": "DE" } }, "surcharge_details": null, "pm_auth_connector": null }, { "payment_method_type": "debit", "payment_experience": null, "card_networks": [ { "card_network": "Visa", "surcharge_details": null, "eligible_connectors": [ "novalnet" ] }, { "card_network": "Mastercard", "surcharge_details": null, "eligible_connectors": [ "novalnet" ] } ], "bank_names": null, "bank_debits": null, "bank_transfers": null, "required_fields": { "billing.address.city": { "required_field": "payment_method_data.billing.address.city", "display_name": "city", "field_type": "user_address_city", "value": "Musterhausen" }, "browser_info.language": { "required_field": "browser_info.language", "display_name": "browser_info_language", "field_type": "browser_language", "value": null }, "billing.email": { "required_field": "payment_method_data.billing.email", "display_name": "email_address", "field_type": "user_email_address", "value": "[email protected]" }, "billing.address.country": { "required_field": "payment_method_data.billing.address.country", "display_name": "country", "field_type": { "user_address_country": { "options": [ "ALL" ] } }, "value": "DE" }, "billing.address.zip": { "required_field": "payment_method_data.billing.address.zip", "display_name": "zip", "field_type": "user_address_pincode", "value": "12345" }, "billing.address.first_name": { "required_field": "payment_method_data.billing.address.first_name", "display_name": "first_name", "field_type": "user_full_name", "value": "Max" }, "billing.address.last_name": { "required_field": "payment_method_data.billing.address.last_name", "display_name": "last_name", "field_type": "user_full_name", "value": "Mustermann" }, "billing.address.line1": { "required_field": "payment_method_data.billing.address.line1", "display_name": "line1", "field_type": "user_address_line1", "value": "1467" }, "billing.address.line2": { "required_field": "payment_method_data.billing.address.line2", "display_name": "line1", "field_type": "user_address_line2", "value": "CA" }, "browser_info.ip_address": { "required_field": "browser_info.ip_address", "display_name": "browser_info_ip_address", "field_type": "browser_ip", "value": null } }, "surcharge_details": null, "pm_auth_connector": null } ] } ], "mandate_payment": null, "merchant_name": "NewAge Retailer", "show_surcharge_breakup_screen": false, "payment_type": "normal", "request_external_three_ds_authentication": false, "collect_shipping_details_from_wallets": false, "collect_billing_details_from_wallets": false, "is_tax_calculation_enabled": false }
Checklist
cargo +nightly fmt --all
cargo clippy