Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connnector): Structure connector enums in separate files for improved team ownership #6459

Merged
merged 15 commits into from
Oct 30, 2024

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Refactoring connector enums to separate files to give code ownership to connector team for connector related changes.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cypress tests should be suffice

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@srujanchikke srujanchikke added the A-connector-integration Area: Connector integration label Oct 29, 2024
@srujanchikke srujanchikke self-assigned this Oct 29, 2024
@srujanchikke srujanchikke requested review from a team as code owners October 29, 2024 07:21
Copy link

semanticdiff-com bot commented Oct 29, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  .github/CODEOWNERS Unsupported file format
  crates/api_models/src/connector_enums.rs  0% smaller
  crates/api_models/src/enums.rs  0% smaller
  crates/api_models/src/lib.rs  0% smaller
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/common_enums/src/enums.rs  0% smaller
  crates/common_enums/src/lib.rs  0% smaller
  crates/router/src/configs/defaults.rs Unsupported file format
  crates/router/src/configs/defaults/payment_connector_required_fields.rs  0% smaller
  scripts/add_connector.sh Unsupported file format

@srujanchikke srujanchikke changed the title fix(connnector): Decouple Connector enums into individual files fix(connnector): Structure connector enums in separate files for improved team ownership Oct 29, 2024
@srujanchikke srujanchikke changed the title fix(connnector): Structure connector enums in separate files for improved team ownership refactor(connnector): Structure connector enums in separate files for improved team ownership Oct 29, 2024
@srujanchikke srujanchikke added the C-refactor Category: Refactor label Oct 29, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit bb246e2 Oct 30, 2024
17 checks passed
@likhinbopanna likhinbopanna deleted the connector_configs branch October 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants