-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connnector): Structure connector enums in separate files for improved team ownership #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
srujanchikke
changed the title
fix(connnector): Decouple Connector enums into individual files
fix(connnector): Structure connector enums in separate files for improved team ownership
Oct 29, 2024
srujanchikke
changed the title
fix(connnector): Structure connector enums in separate files for improved team ownership
refactor(connnector): Structure connector enums in separate files for improved team ownership
Oct 29, 2024
Co-authored-by: Sanchith Hegde <[email protected]>
SanchithHegde
approved these changes
Oct 29, 2024
deepanshu-iiitu
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactoring connector enums to separate files to give code ownership to connector team for connector related changes.
Additional Changes
Motivation and Context
How did you test it?
Cypress tests should be suffice
Checklist
cargo +nightly fmt --all
cargo clippy