-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(core): interpolate success_based_routing config params with their specific values #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
prajjwalkumar17
changed the title
Refactor/grpc sr
Refactor(core): interpolate params with their specific values
Oct 28, 2024
prajjwalkumar17
changed the title
Refactor(core): interpolate params with their specific values
Refactor(core): interpolate success_based_routing config params with their specific values
Nov 5, 2024
prajjwalkumar17
requested review from
Chethan-rao,
NishantJoshi00 and
apoorvdixit88
November 5, 2024 14:22
Chethan-rao
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could u move the startup log which is getting logged even when feature is disabled
Chethan-rao
requested changes
Nov 7, 2024
Chethan-rao
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test cases screen shots for displaying the redis keys
Chethan-rao
approved these changes
Nov 7, 2024
NishantJoshi00
approved these changes
Nov 7, 2024
good find |
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
…their specific values (#6448) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
…their specific values (#6448) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This will interpolate the success_based_routing config params with the specific payment's values:
So for now the redis key was something like PaymentMethod:Currency
After this change it will be something like Card:USD
Additional Changes
Motivation and Context
How did you test it?
This is tested locally can't be tested on sbx or integ as it requires access for redis.
Checklist
cargo +nightly fmt --all
cargo clippy