Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added grpc based health check #6441

Merged
merged 23 commits into from
Nov 26, 2024
Merged

feat: Added grpc based health check #6441

merged 23 commits into from
Nov 26, 2024

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Oct 25, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implemented gRPC based health check

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested locally

curl --location --request GET 'http://localhost:8080/health/ready' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_Li5BLbzNIHjf2t0J6kYgS7sQurtmLubs1sGAxTE6MVo59aMBEMDSK6Qt8me7kJZQ'

Response

{
    "database": true,
    "redis": true,
    "analytics": true,
    "opensearch": true,
    "outgoing_request": true,
    "grpc_health_check": {
        "dynamic_routing_service": true
    }
}
image

Response when runtime config is disabled

{
    "database": true,
    "redis": true,
    "analytics": true,
    "opensearch": true,
    "outgoing_request": true,
    "grpc_health_check": {}
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sarthak1799 Sarthak1799 self-assigned this Oct 25, 2024
@Sarthak1799 Sarthak1799 requested review from a team as code owners October 25, 2024 19:11
Copy link

semanticdiff-com bot commented Oct 25, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/external_services/build.rs  51% smaller
  crates/external_services/src/grpc_client.rs  1% smaller
  config/config.example.toml Unsupported file format
  config/deployments/env_specific.toml Unsupported file format
  crates/api_models/Cargo.toml Unsupported file format
  crates/api_models/src/health_check.rs  0% smaller
  crates/external_services/src/grpc_client/dynamic_routing.rs  0% smaller
  crates/external_services/src/grpc_client/health_check_client.rs  0% smaller
  crates/router/Cargo.toml Unsupported file format
  crates/router/src/core/health_check.rs  0% smaller
  crates/router/src/routes/health.rs  0% smaller
  crates/storage_impl/src/errors.rs  0% smaller
  proto/health_check.proto Unsupported file format

@Sarthak1799 Sarthak1799 linked an issue Oct 25, 2024 that may be closed by this pull request
crates/external_services/build.rs Outdated Show resolved Hide resolved
crates/api_models/src/health_check.rs Outdated Show resolved Hide resolved
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit e922f96 Nov 26, 2024
21 checks passed
@likhinbopanna likhinbopanna deleted the dynamo-health-check branch November 26, 2024 13:58
pixincreate added a commit that referenced this pull request Nov 27, 2024
…ed-cypress

* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2024.11.27.0
  fix(core): add payment_id as query param in merchant return url (#6665)
  feat(connector): [Netcetera] add sca exemption (#6611)
  feat(payments): propagate additional payment method data for google pay during MIT (#6644)
  feat: Added grpc based health check (#6441)
  feat(analytics): add `sessionized_metrics` for disputes analytics (#6573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: add deep health check for dynamic routing
4 participants