feat(cypress-test): include worldpay's request / response structure for test suite #6420
Conversation
|
Review changes with SemanticDiff. Analyzed 9 of 9 files. Overall, the semantic diff is 2% smaller than the GitHub diff.
|
pixincreate
added
A-CI-CD
…nectorData or fallbackData
…or SaveCardFlow during auto capture
There was a problem hiding this comment.
since this affects almost every connector out there, it would be great if you could run the test against all the connectors once to confirm. yes, multiple connectors do fail due to blockers that cypress cannot handle (at least, until now).
you can make use of scripts/execute_cypress.sh script and run against multiple connectors in parallel.
please refer to README to know more about running in parallel / multiple connectors at once.
| export function getConnectorFlowDetails(connectorData, commonData, key) { | ||
| let data = connectorData[key] === undefined ? commonData[key] : connectorData[key]; | ||
| return data; | ||
| } | ||
|
|
There was a problem hiding this comment.
if we could do a deep merge of commons.js and <connector>.js in a safer way that does not overrides the existing configs from <connector>.js, this change would never be needed.
as discussed, deep merge will for sure add overhead, but would reduce complexity is what i feel.
this should also work, but i do think this will have a very limited scope of use.
There was a problem hiding this comment.
It does have a very limited scope as of now, we can remove this once we introduce custom deep merge (merge everything except Response). But we can let it be for now, since it's out of scope of this PR
SanchithHegde
removed
the
S-waiting-on-review
Type of Change
Description
Described in #6316 point # 4 (read comments)
Additional Changes
Motivation and Context
Helps in sanity testing of Worldpay connector.
How did you test it?
Locally using
npm run cypress:paymentsChecklist
cargo +nightly fmt --allcargo clippy