refactor(connector): [AIRWALLEX, MULTISAFEPAY, RAZORPAY, SHIFT4, WORLDPAY, ZSL] Move connectors from router to hyperswitch_connectors crate
#6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spritianeja03
changed the title
spritianeja03
changed the title
deepanshu-iiitu
requested changes
Oct 30, 2024
| .as_ref() | ||
| .and_then(|billing_address| billing_address.get_optional_full_name()) | ||
| } | ||
| } | ||
| pub trait PaymentsPreProcessingRequestData { |
There was a problem hiding this comment.
Suggested change
| pub trait PaymentsPreProcessingRequestData { | |
| pub trait PaymentsPreProcessingData { |
Rename this trait to PaymentsPreProcessingData
There was a problem hiding this comment.
Another struct with the name PaymentsPreProcessingData already exists in [router_request_types.rs] file
So upon renaming the trait PaymentsPreProcessingRequestData to this name, it gives an error
Comment on lines
18
to
19
| /// Worldpay's unique reference ID for a request TODO: Move to hyperswitch_connectors/constants once Worldpay is moved to connectors crate | ||
| pub const WP_CORRELATION_ID: &str = "WP-CorrelationId"; |
There was a problem hiding this comment.
Move this const definition to crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs
crates/router/src/core/utils.rs
Outdated
| @@ -1310,7 +1310,7 @@ pub fn get_connector_label( | |||
| format!("{connector_name}_{business_country}_{business_label}"); | |||
|
|
|||
| // Business sub label is currently being used only for cybersource | |||
| // To ensure backwards compatibality, cybersource mca's created before this change | |||
| // To ensure backwards compatibality, cybersource mca's created be this change | |||
There was a problem hiding this comment.
Why is this done? Remove this change if not required.
| connectors::Zen, | ||
| connectors::Zsl, |
There was a problem hiding this comment.
Values for default_imp_for_calculate_tax are not sorted alphabetically.
deepanshu-iiitu
previously approved these changes
Oct 30, 2024
SanchithHegde
changed the title
router to hyperswitch_connectors crate
sai-harsha-vardhan
previously approved these changes
Oct 30, 2024
crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs
Outdated
Show resolved
Hide resolved
| strum = { version = "0.26", features = ["derive"] } | ||
| time = "0.3.35" | ||
| url = "2.5.0" | ||
| urlencoding = "2.1.3" |
There was a problem hiding this comment.
Can we confirm if we can use the url_encode() utility method instead of the urlencoding crate?
There was a problem hiding this comment.
This function url_encode() supports serialization only for maps and structs, hence we cannot use this.
spritianeja03
dismissed stale reviews from sai-harsha-vardhan and deepanshu-iiitu
via
268ccc1
deepanshu-iiitu
previously approved these changes
Oct 30, 2024
added 2 commits
October 30, 2024 19:13
SanchithHegde
previously approved these changes
Oct 30, 2024
spritianeja03
dismissed stale reviews from SanchithHegde and deepanshu-iiitu
via
a39899e
deepanshu-iiitu
approved these changes
Nov 4, 2024
SanchithHegde
approved these changes
Nov 4, 2024
sai-harsha-vardhan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Moved connector Airwallex, Multisafepay, Razorpay, Shift4, Worldpay and Zsl from Router crate to hyperswitch_connectors crate.
Additional Changes
Motivation and Context
How did you test it?
Multisafepay
Request
Response
Request
Response
Shift4
Request
Response
Checklist
cargo +nightly fmt --allcargo clippy