-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): update vector config #6365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change the merchant_id value that contains publishable_key to actual merchant_id value - an sdk_map.csv is used to keep map of publishable_key -> merchant_id
maverox
added
M-configuration-changes
Metadata: This PR involves configuration changes
C-feature
Category: Feature request or enhancement
labels
Oct 18, 2024
maverox
changed the title
Feat(config): Update Vector Config
feat(config): Update Vector Config
Oct 18, 2024
ShivanshMathurJuspay
approved these changes
Oct 23, 2024
maverox
changed the title
feat(config): Update Vector Config
feat(config): update Vector Config
Oct 23, 2024
maverox
changed the title
feat(config): update Vector Config
feat(config): update ector config
Oct 23, 2024
maverox
changed the title
feat(config): update ector config
feat(config): update vector config
Oct 23, 2024
lsampras
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a placeholder csv?
tsdk02
approved these changes
Oct 24, 2024
Yes for the enrichment to work I think we need csv but I am not sure what you mean by placeholder? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-feature
Category: Feature request or enhancement
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Fixes #6364
Description
sdk
logs that fetches a value from an enrichment tablesdk_map
populated by filesdk_map.csv
and updates the fields using this value.opensearch
logs sinkImportant Notes
Please ensure that the
sdk_map.csv
file is properly formatted and accessible at the specified path. The name of the file should also match the name of the table in config i.esdk_map
.Additional Changes
Motivation and Context
Prior Behaviour
observed
merchant_id: "pk_dev*****"
.expected
merchant_id: "merchant_*****"
.last_synced
,sign_flag
andclickhouse_database
that needed to be ignoredIntentions
How did you test it?
Running it locally to check logs added in console (sdk) logs & opensearch
sdk_logs
I created a dummy_transform event that inserted a
publishable_key
in merchant_id field and passed it to the actualtransform function and then captured the output on a
console sink
opensearch logs
for this simply created a payment and compared the logs from kafka topics and opensearch entries
kafka ui
opensearch dashboard (no last_synced entry found)
Checklist
cargo +nightly fmt --all
cargo clippy