-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): [WorldPay] migrate from modular to standard payment APIs #6317
Conversation
…n > 128 characters
… update v2_migrations down query
Review changes with SemanticDiff. Analyzed 7 of 12 files. Overall, the semantic diff is 36% smaller than the GitHub diff.
|
@@ -171,11 +171,23 @@ impl PaymentAttempt { | |||
merchant_id: &common_utils::id_type::MerchantId, | |||
connector_txn_id: &str, | |||
) -> StorageResult<Self> { | |||
let (txn_id, txn_data) = common_utils::types::ConnectorTransactionId::form_id_and_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @Narayanbhat166 can you pls review this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be reverting this for now, can be added and discussed later.
Why?
This was added for Worldpay, and they send back transactionReference (payment_attempt_id
for hyperswitch), so this query will not be invoked
Type of Change
Description
Described in #6316
Additional Changes
Motivation and Context
How did you test it?
Things to test
Notes
merchant_secret
during MCA creation)1. Create and capture
cURL
Response
2. Create a payment using manual capture
cURL
Response
cURL (capture)
Response
3. Full amount refunds
cURL
Response
4. Retrieve payment
cURL
curl --location --request GET 'http://localhost:8080/payments/pay_xeIPwzyWR0LgJdmy0naH?force_sync=true'
--header 'Accept: application/json'
--header 'api-key: dev_sMl3D9efytjSoXznSOKCv5PHyql50M1BMhU8e7qsa5m6mXxHvyROVg7cER7AWue9'
Response
Checklist
cargo +nightly fmt --all
cargo clippy