Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(connector): [ELAVON] Template PR #6309

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Feat(connector): [ELAVON] Template PR #6309

merged 2 commits into from
Nov 5, 2024

Conversation

sumanmaji4
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template code added for new connector Elavon
https://developer.elavon.com/products/xml-api/v1/api-reference#tag/Process-Transaction-Online

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sumanmaji4 sumanmaji4 requested review from a team as code owners October 14, 2024 13:36
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 14, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  99% smaller
  crates/hyperswitch_connectors/src/connectors.rs  81% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  19% smaller
  crates/router/src/core/payments/flows.rs  19% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  18% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  18% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/hyperswitch_connectors/src/connectors/elavon.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/elavon/transformers.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/elavon.rs  0% smaller
  crates/router/tests/connectors/main.rs  0% smaller
  crates/router/tests/connectors/sample_auth.toml Unsupported file format
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

deepanshu-iiitu
deepanshu-iiitu requested changes Oct 14, 2024
View reviewed changes
crates/hyperswitch_connectors/src/default_implementations_v2.rs Outdated
@@ -236,6 +237,7 @@ macro_rules! default_imp_for_new_connector_integration_refund {
}

default_imp_for_new_connector_integration_refund!(
connectors::Elavon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain alphabetical order

@sumanmaji4 sumanmaji4 force-pushed the elavon-connector-template branch from 5030916 to af6dfc7 Compare October 14, 2024 14:53
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Oct 14, 2024
SanchithHegde
SanchithHegde previously approved these changes Oct 16, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@sumanmaji4 sumanmaji4 force-pushed the elavon-connector-template branch from 725be4b to 2ded2e2 Compare October 23, 2024 15:34
cookieg13
cookieg13 previously approved these changes Oct 28, 2024
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Oct 29, 2024
View reviewed changes
@sumanmaji4 sumanmaji4 force-pushed the elavon-connector-template branch from 457cea8 to 76b3a0a Compare November 4, 2024 06:30
cookieg13
cookieg13 reviewed Nov 4, 2024
View reviewed changes
crates/common_enums/src/enums.rs Outdated
@@ -142,6 +140,133 @@ pub enum AttemptStatus {
DeviceDataCollectionPending,
}

#[derive(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these extra changes

cookieg13
cookieg13 reviewed Nov 4, 2024
View reviewed changes
crates/api_models/src/enums.rs Outdated
@@ -27,6 +27,302 @@ pub enum RoutingAlgorithm {
Custom,
}

/// A connector is an integration to fulfill payments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these extra changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase with main

cookieg13
cookieg13 reviewed Nov 4, 2024
View reviewed changes
crates/api_models/src/enums.rs Outdated
@@ -1,10 +1,10 @@
use std::str::FromStr;

pub use common_enums::*;
#[cfg(feature = "dummy_connector")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookieg13 I encountered some merge conflicts due to these changes, so it seems they may all be needed going forward.

@sumanmaji4 sumanmaji4 force-pushed the elavon-connector-template branch from efc701c to 4f6bb81 Compare November 4, 2024 12:10
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 4, 2024
@sumanmaji4 sumanmaji4 force-pushed the elavon-connector-template branch from 8825c79 to c9c16d6 Compare November 5, 2024 07:07
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 5, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 5, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit b481e5c Nov 5, 2024
16 of 17 checks passed
@likhinbopanna likhinbopanna deleted the elavon-connector-template branch November 5, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookieg13 cookieg13 cookieg13 approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@sumanmaji4 sumanmaji4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sumanmaji4 @SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan @cookieg13 @likhinbopanna