Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated db_metrics Operation to Use Count Instead of Filter in get_intent_status_with_count #6295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated db_metrics Operation to Use Count Instead of Filter in get_intent_status_with_count #6295

wants to merge 2 commits into from

Conversation

ayan-joshi
Copy link
Contributor

Made changes for db_metrics

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • [ x] Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Made changes as asked in the issue

Close the issue #5988
@apoorvdixit88 have a look

@ayan-joshi
commit
553d7c0 
Made changes for db_metrics
@ayan-joshi ayan-joshi requested a review from a team as a code owner October 11, 2024 19:01
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 11, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 95% smaller than the GitHub diff.

Filename Status
✔️ crates/storage_impl/src/payments/payment_intent.rs 94.14% smaller

@ayan-joshi
Copy link
Contributor Author

@apoorvdixit88 have a look

@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 24, 2024
@apoorvdixit88 apoorvdixit88 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 24, 2024
@ayan-joshi
Copy link
Contributor Author

@apoorvdixit88 I hope its fine now

@apoorvdixit88
Copy link
Contributor

@apoorvdixit88 I hope its fine now

Hey @ayan-joshi checks are still failing.

  • For Formatting you can use: cargo +nightly fmt --all
  • Also please follow convention for the PR title

You also need to attach the test cases, the expected behaviour of the api shouldn't change. (Will mention the curl in the issue itself).

@apoorvdixit88 apoorvdixit88 linked an issue Oct 25, 2024 that may be closed by this pull request
[REFACTOR] Update db_metrics Operation to Use Count Instead of Filter in get_intent_status_with_count #5988
Open
1 task
@apoorvdixit88 apoorvdixit88 added C-bug Category: Bug C-refactor Category: Refactor labels Oct 25, 2024
@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdixit88 apoorvdixit88 Awaiting requested review from apoorvdixit88

@dracarys18 dracarys18 Awaiting requested review from dracarys18

At least 2 approving reviews are required to merge this pull request.

Assignees

@ayan-joshi ayan-joshi

Labels
C-bug Category: Bug C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Update db_metrics Operation to Use Count Instead of Filter in get_intent_status_with_count
3 participants
@ayan-joshi @apoorvdixit88 @gorakhnathy7