-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db): implement MerchantAccountInteraface
for Mockdb
#6283
Conversation
Changed Files
|
@gorakhnathy7 I'm done in implementing the interface. Please review and provide if there are any comments. |
It's been quite some time since this pr is reviewed. |
@SanchithHegde Can you check now, I've found an innovative way without cloning and skipping lot of boilerplate to update merchant account by implementing a special trait to Option |
@SanchithHegde, can you review now re-designed merchantaccount updates for mockdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me!
Done |
MerchantAccountInteraface
for Mockdb
@akhildevelops Could you please address the failing clippy / compilation checks? |
@SanchithHegde Can you please check now by running workflows. |
Type of Change
Description
Mockdb is a stub to avoid costly interactions with db during testing. This PR powers mockdb to have MerchantAccountInterface for adding, deleting, searching merchant accounts.
Additional Changes
Motivation and Context
Fixes #2438
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy