-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments_v2): add payment_confirm_intent api endpoint #6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarnura
previously approved these changes
Oct 23, 2024
crates/router/src/core/payments/operations/payment_confirm_intent.rs
Outdated
Show resolved
Hide resolved
…yperswitch` option only if apple pay token decryption flow is supported for the connector (#6386)
…nd Zen from Router to Hyperswitch Connector Trait (#6261) Co-authored-by: Spriti Aneja <[email protected]> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
jarnura
approved these changes
Oct 24, 2024
sai-harsha-vardhan
approved these changes
Oct 24, 2024
ShankarSinghC
approved these changes
Oct 24, 2024
apoorvdixit88
approved these changes
Oct 24, 2024
Comment on lines
+77
to
+81
// // status: self.status, | ||
// // error_message: self.error_message, | ||
// // surcharge_amount: self.surcharge_amount, | ||
// // tax_amount: self.tax_amount, | ||
// // payment_method_id: self.payment_method_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having two set of comment //
is redundant?
lsampras
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces the
payment-confirm-intent
endpoint. This is used to confirm the payment intent with payment method data.This PR also includes changes to the payment attempt for api v2. Few columns have been added and few have been removed. The major changes that have been made to payment attempt are
This PR contains only the minimum changes that are required to call the connector.
Additional Changes
Add new api endpoint to payments. The openapi reference has been generated.
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy