feat(connector): [Nexixpay] add mandates flow for cards #6259

mrudulvajpayee4935 · 2024-10-08T06:01:58Z

Type of Change

Description

Integrate mandates flow for card payments.
https://developer.nexi.it/en/funzionalita-/pagamenti-ricorrenti

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cypress test:

1) Multiuse mandates

2) Singleuse mandates

3) Test cases in the headless mode

Note:

Skipping no3ds test cases as it is not supported by nexixpay
Remaining few test cases in headless mode is failing due to inconsistency in test environment from the connector - cc: @likhinbopanna @Gnanasundari24 **

Create Call

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data '{
    "amount": 3545,
    "currency": "EUR",
    "confirm": false,
    "customer_id": "tester799",
    "setup_future_usage": "off_session"
}'

Confirm Call

curl --location 'http://localhost:8080/payments/pay_sFK1K3juhPteyDXgEH8X/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data-raw '{
    "payment_method": "card",
    "return_url": "https://google.com",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4349940199004549",
            "card_exp_month": "12",
            "card_exp_year": "30",
            "card_holder_name": "Joseph Does",
            "card_cvc": "396"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "IT",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "IT",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "customer_acceptance": {
        "acceptance_type": "offline"
    }
}'

MIT Call

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data '{
    "amount": 3545,
    "currency": "EUR",
    "confirm": true,
    "customer_id": "tester799",
    "recurring_details": {
        "type": "payment_method_id",
        "data": "pm_WqDpelm1rZ4yvUkf579X"
    },
    "off_session": true
}'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-10-08T06:02:01Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs	39% smaller
crates/hyperswitch_connectors/src/connectors/nexixpay.rs	15% smaller
cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js	1% smaller
crates/hyperswitch_connectors/src/utils.rs	0% smaller
crates/router/src/configs/defaults/payment_connector_required_fields.rs	0% smaller

awasthi21 · 2024-11-08T07:19:07Z

crates/hyperswitch_connectors/src/connectors/nexixpay.rs

-            data: data.clone(),
-            http_code: res.status_code,
-        })
+        if data.request.connector_mandate_id().is_none() {


this check won't be needed if we use an enum for the PaymentsResponse
enum NexixpayResponse { PaymentsPresonse(NexixpayPaymentsResponse), MandateResponse(NexixpayMandateResponse), }
`

Take reference from Fiuu: Transformers

#[serde(untagged)] pub enum FiuuPaymentsResponse { PaymentResponse(Box<PaymentsResponse>), QRPaymentResponse(Box<DuitNowQrCodeResponse>), Error(FiuuErrorResponse), RecurringResponse(Vec<Box<FiuuRecurringResponse>>), }

srujanchikke

Please add cypress test cases as well.

srujanchikke · 2024-11-11T07:37:40Z

crates/hyperswitch_connectors/src/connectors/nexixpay.rs

        connectors: &Connectors,
    ) -> CustomResult<String, errors::ConnectorError> {
-        Ok(format!("{}/orders/3steps/init", self.base_url(connectors)))
+        if req.request.connector_mandate_id().is_none() {


can we check for off_session instead

tried this but it creates problem as normal payment and cit payment both use same endpoint.

srujanchikke · 2024-11-11T07:39:30Z

crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs

+            name: item.router_data.get_billing_full_name()?,
+            street: item.router_data.get_billing_line1()?,
+            city: item.router_data.get_billing_city()?,
+            post_code: item.router_data.get_billing_zip()?,
+            country: item.router_data.get_billing_country()?,
+        };


All required fields should be added in payment_connector_required_fields.rs file

Its already added

srujanchikke · 2024-11-11T07:39:59Z

crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs

+        let customer_info = CustomerInfo {
+            card_holder_name: item.router_data.get_billing_full_name()?,
+            billing_address: billing_address.clone(),
+            shipping_address: Some(billing_address),


why are we hardcoding shipping address to billing_address ?

mrudulvajpayee4935 · 2024-11-12T16:07:58Z

Please add cypress test cases as well.
Could not run cypress tests since we don't have support for 3ds mandates cypress tests. cc: @likhinbopanna

Gnanasundari24 · 2024-11-26T08:19:16Z

@mrudulvajpayee4935 Please run the cypress testcases for nexixpay

mrudulvajpayee4935 · 2024-11-26T09:15:10Z

have support for 3ds mandates cypress tests.

do we have support for 3ds mandates cypress tests? @Gnanasundari24

likhinbopanna · 2024-11-29T09:56:14Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

        customer_acceptance: null,
        setup_future_usage: "on_session",
+        billing: {


Can you declare billing as const and use it everywhere else the billing address are same

pixincreate · 2024-12-02T16:06:02Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

-  card_exp_year: "50",
+  card_number: "4111111111111111",
+  card_exp_month: "08",
+  card_exp_year: "25",


august will come sooner than you might expect:

Suggested change

card_exp_year: "25",

card_exp_year: "50",

pixincreate · 2024-12-02T16:07:33Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

+  customer_acceptance: {
+    acceptance_type: "offline",
+    accepted_at: "1963-05-03T04:07:52.723Z",
+    online: {
+      ip_address: "125.0.0.1",
+      user_agent: "amet irure esse",
+    },
+  },


In L53 you've declared customerAcceptance. Move it above, and re-use it here and below.

pixincreate · 2024-12-02T16:09:19Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

+        status: 501,
+        body: {
+          error: {
+            type: "invalid_request",
+            message: "No threeds is not supported",
+            code: "IR_00",


Are you sure about this?

status is expected to be 400. Unless the connector has specific error message, this line is not needed as it will be handled by Commons.

Same applies to else where below.

pixincreate · 2024-12-02T16:10:57Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

+      },
+      Response: {
+        status: 200,
+        trigger_skip: true,


You will have to change the implementation once #6588 gets merged here and else where for trigger_skip

pixincreate · 2024-12-02T16:12:24Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

+        status: 501,
+        body: {
+          error: {
+            type: "invalid_request",
+            message: "No threeds is not supported",
+            code: "IR_00",
+          },
+        },


again, since the same object is used in multiple places, this can be re-used by creating a constant object.

pixincreate

other than that, looks good to me.

i also recommend you to run tests locally to see if everything works.

pixincreate · 2024-12-04T09:34:43Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

@@ -1,3 +1,13 @@
+import { getCustomExchange } from "./Commons";


can you check the lints?

pixincreate · 2024-12-04T09:35:27Z

cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js

+    card_isin: "411111",
+    card_extended_bin: null,
+    card_exp_month: "08",
+    card_exp_year: "25",


increase this year to a later date. august 2025 will come sooner than you might expect.

mrudulvajpayee4935 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Oct 8, 2024

mrudulvajpayee4935 self-assigned this Oct 8, 2024

mrudulvajpayee4935 requested review from a team as code owners October 8, 2024 06:01

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from caa6bdc to 05708e2 Compare November 8, 2024 02:53

awasthi21 reviewed Nov 8, 2024

View reviewed changes

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from c50b691 to e9826fe Compare November 10, 2024 14:25

awasthi21 previously approved these changes Nov 11, 2024

View reviewed changes

srujanchikke reviewed Nov 11, 2024

View reviewed changes

mrudulvajpayee4935 dismissed awasthi21’s stale review via 4e5a88c November 12, 2024 16:32

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 26f8b4a to 4f85626 Compare November 13, 2024 07:30

srujanchikke previously approved these changes Nov 13, 2024

View reviewed changes

awasthi21 previously approved these changes Nov 13, 2024

View reviewed changes

SanchithHegde removed request for a team November 13, 2024 12:06

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 4f85626 to 82749d8 Compare November 13, 2024 13:21

mrudulvajpayee4935 dismissed stale reviews from awasthi21 and srujanchikke via aabcadc November 15, 2024 10:00

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 82749d8 to aabcadc Compare November 15, 2024 10:00

awasthi21 previously approved these changes Nov 15, 2024

View reviewed changes

srujanchikke previously approved these changes Nov 15, 2024

View reviewed changes

mrudulvajpayee4935 dismissed awasthi21’s stale review via 26496f9 November 28, 2024 09:17

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 0394a63 to 26496f9 Compare November 28, 2024 09:17

mrudulvajpayee4935 requested a review from a team as a code owner November 28, 2024 09:17

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 54743ec to 3e810f8 Compare November 29, 2024 07:40

likhinbopanna reviewed Nov 29, 2024

View reviewed changes

awasthi21 previously approved these changes Nov 29, 2024

View reviewed changes

mrudulvajpayee4935 dismissed awasthi21’s stale review via 09e3b1b December 2, 2024 12:38

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 09e3b1b to 1eba637 Compare December 2, 2024 12:43

pixincreate reviewed Dec 2, 2024

View reviewed changes

Mrudul Vajpayee added 9 commits December 4, 2024 12:15

mandates support

2b2860d

refactor NexixpayPaymentsResponse

cc824d0

use shipping address

9e3339f

add debit card required fields

bcc5e53

rebase

2ccd11a

add mandates cypress tests

d90cc3b

no3ds not support test support

a5baef0

handle not support cypress test

73fe1ef

resolve cypress comments

8f1f9da

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 3789380 to 4b01f10 Compare December 4, 2024 08:14

pixincreate reviewed Dec 4, 2024

View reviewed changes

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from 4b01f10 to 176d2aa Compare December 4, 2024 09:54

update sip skip logic

0cd2a9c

mrudulvajpayee4935 force-pushed the nexixpay-card-mandates branch from a216702 to 0cd2a9c Compare December 4, 2024 10:35

likhinbopanna approved these changes Dec 4, 2024

View reviewed changes

awasthi21 approved these changes Dec 4, 2024

View reviewed changes

srujanchikke approved these changes Dec 4, 2024

View reviewed changes

pixincreate approved these changes Dec 4, 2024

View reviewed changes

likhinbopanna added this pull request to the merge queue Dec 5, 2024

Merged via the queue into main with commit 62521f3 Dec 5, 2024
16 of 18 checks passed

likhinbopanna deleted the nexixpay-card-mandates branch December 5, 2024 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Nexixpay] add mandates flow for cards #6259

feat(connector): [Nexixpay] add mandates flow for cards #6259

mrudulvajpayee4935 commented Oct 8, 2024 •

edited

Loading

semanticdiff-com bot commented Oct 8, 2024 •

edited

Loading

awasthi21 Nov 8, 2024

awasthi21 Nov 8, 2024

srujanchikke left a comment

srujanchikke Nov 11, 2024

mrudulvajpayee4935 Nov 12, 2024

srujanchikke Nov 11, 2024

mrudulvajpayee4935 Nov 12, 2024

srujanchikke Nov 11, 2024

mrudulvajpayee4935 commented Nov 12, 2024

Gnanasundari24 commented Nov 26, 2024

mrudulvajpayee4935 commented Nov 26, 2024

likhinbopanna Nov 29, 2024

pixincreate Dec 2, 2024

pixincreate Dec 2, 2024

pixincreate Dec 2, 2024

pixincreate Dec 2, 2024

pixincreate Dec 2, 2024

pixincreate left a comment

pixincreate Dec 4, 2024

pixincreate Dec 4, 2024

		@@ -1,3 +1,13 @@
		import { getCustomExchange } from "./Commons";

feat(connector): [Nexixpay] add mandates flow for cards #6259

feat(connector): [Nexixpay] add mandates flow for cards #6259

Conversation

mrudulvajpayee4935 commented Oct 8, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Cypress test:

Create Call

Confirm Call

MIT Call

Checklist

semanticdiff-com bot commented Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srujanchikke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrudulvajpayee4935 commented Nov 12, 2024

Gnanasundari24 commented Nov 26, 2024

mrudulvajpayee4935 commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pixincreate left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrudulvajpayee4935 commented Oct 8, 2024 •

edited

Loading

semanticdiff-com bot commented Oct 8, 2024 •

edited

Loading