Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): add amount conversion framework to nexinets #6201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(router): add amount conversion framework to nexinets #6201

wants to merge 6 commits into from

Conversation

hex1c
Copy link
Contributor

@hex1c hex1c commented Oct 2, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Minor refactoring to standardizeNexinets connector to use the conversion framework to reduce potential inconsistencies in managing amounts fixes #6095 .

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hex1c hex1c requested review from a team as code owners October 2, 2024 18:55
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 2, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/types/api.rs  85% smaller
  crates/router/tests/connectors/nexinets.rs  69% smaller
  crates/hyperswitch_connectors/src/connectors/nexinets/transformers.rs  38% smaller
  crates/hyperswitch_connectors/src/connectors/nexinets.rs  30% smaller

@hex1c hex1c changed the title refactor(router):add amount conversion framework to nexinets refactor(router): add amount conversion framework to nexinets Oct 2, 2024
@gorakhnathy7 gorakhnathy7 requested review from swamu and swangi-kumari and removed request for swamu October 3, 2024 05:42
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Oct 3, 2024
@hex1c hex1c force-pushed the nexinets-conversion-fw branch from daabb8c to 5a74321 Compare October 5, 2024 06:02
@hex1c hex1c force-pushed the nexinets-conversion-fw branch from 5a74321 to ab32e8a Compare October 5, 2024 06:03
@awasthi21 awasthi21 requested review from awasthi21 and removed request for awasthi21 October 14, 2024 07:36
awasthi21
awasthi21 reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@awasthi21 awasthi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the CI checks

crates/router/src/connector/nexinets.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nexinets.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nexinets.rs Outdated Show resolved Hide resolved
@hex1c
Copy link
Contributor Author

hex1c commented Oct 14, 2024

@awasthi21 review changes done

@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 15, 2024
@gorakhnathy7 gorakhnathy7 requested review from dracarys18 and removed request for swangi-kumari and awasthi21 October 17, 2024 23:21
@deepanshu-iiitu
Copy link
Contributor

@hex1c Please resolve the conflicts

@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
@gorakhnathy7
Copy link
Collaborator

Hey @hex1c
Can you please look into the comments, and make the changes!

@hex1c hex1c force-pushed the nexinets-conversion-fw branch from d4ce330 to 920454c Compare November 10, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracarys18 dracarys18 Awaiting requested review from dracarys18

@deepanshu-iiitu deepanshu-iiitu Awaiting requested review from deepanshu-iiitu

@awasthi21 awasthi21 Awaiting requested review from awasthi21

At least 2 approving reviews are required to merge this pull request.

Assignees

@hex1c hex1c

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [NEXINETS] Add amount conversion framework to Nexinets
5 participants
@hex1c @deepanshu-iiitu @gorakhnathy7 @awasthi21 @swangi-kumari