fix(docker): Integrate Hyperswitch Web Client and Control Center into Docker Compose Setup #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayabee19
changed the title
akshayabee19
changed the title
| @@ -51,7 +51,7 @@ services: | |||
| ports: | |||
| - "8080:8080" | |||
| networks: | |||
| - router_net | |||
| - hyperswitch_net | |||
There was a problem hiding this comment.
Please revert this change, and replace hyperswitch_net with router_net everywhere else.
Comment on lines
+72
to
+74
| build: | ||
| context: ./docker | ||
| dockerfile: web.Dockerfile |
There was a problem hiding this comment.
Could you include the Dockerfile in the PR?
Comment on lines
+112
to
+114
| networks: | ||
| hyperswitch_net: | ||
| #network configurations here if required |
There was a problem hiding this comment.
We already have the network defined at the beginning of the file.
SanchithHegde
added
A-infra
lsampras
reviewed
Apr 24, 2024
Comment on lines
+103
to
+104
| networks: | ||
| - hyperswitch_net |
There was a problem hiding this comment.
this might not be needed since there isn't any inter-service communication happening here...
since all communication happens on the host machine and is initiated by browser
|
Closing this in favor of #4197. |
SanchithHegde
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This docker-compose.yml file now includes code for setting up the hyperswitch-web and hyperswitch-control-center services along with the existing hyperswitch-server service. These services are configured to communicate with each other within the hyperswitch_net network, ensuring better isolation and reliability.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy