Added dockerfile for web and updated docker-compose #4186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile.web-client
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Use official Node.js image as the base image for web client | |||
| FROM node:14 as web-client-builder | |||
There was a problem hiding this comment.
Could we use a more recent version of node?
Dockerfile.web-client
Outdated
Comment on lines
7
to
14
| # Copy package.json and package-lock.json to the working directory | ||
| COPY package*.json ./ | ||
|
|
||
| # Install dependencies | ||
| RUN npm install | ||
|
|
||
| # Copy the rest of the application code to the working directory | ||
| COPY . . |
There was a problem hiding this comment.
The source of the web client and demo app can be found at https://github.com/juspay/hyperswitch-web.
So you'd have to either add this Dockerfile there, or add steps in this Dockerfile to clone the repository.
Comment on lines
+125
to
+127
| web-client: | ||
| # Configuration for the web client service | ||
| image: <web_client_image>:<tag> |
There was a problem hiding this comment.
As it stands, we don't have Docker images for the web client on Docker Hub, we'll have to build and start the service instead.
SanchithHegde
added
A-infra
|
Closing this in favor of #4197. |
SanchithHegde
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
I manually tested the changes by spinning up the Docker Compose environment and verifying that the web client and control center services are properly integrated with the existing services. All services were able to communicate with each other as expected.
Checklist
cargo +nightly fmt --allcargo clippy