Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Noon] add new field max_amount to mandate request #3591

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

AkshayaFoiger
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger commented Feb 8, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves #3445
Original PR: #3481

Note
1.While connector create ensure test_mode is set to true
2.Ensure the currency passed is AED and country is AE

How did you test it?

1.Create a CIT with noon
with

  "connector_metadata": {
        "noon": {
            "order_category": "pay"
        }
    }
Screenshot 2024-01-12 at 2 16 26 PM without order_category it should throw an error Screenshot 2024-01-12 at 2 16 44 PM
  1. Make a MIT
Screenshot 2024-01-12 at 2 02 35 PM

3.Test through stripe compatibility layer
CIT
Screenshot 2024-02-06 at 7 11 36 PM

MIT
Screenshot 2024-02-06 at 7 11 30 PM

MIT with greater amount
Screenshot 2024-02-06 at 7 11 19 PM

4.Test Applepay mandates

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested review from a team as code owners February 8, 2024 07:45
@AkshayaFoiger AkshayaFoiger changed the base branch from main to hotfix-2024.02.02.0 February 8, 2024 07:45
@AkshayaFoiger AkshayaFoiger changed the base branch from hotfix-2024.02.02.0 to hotfix-2024.01.24.1 February 8, 2024 07:49
@AkshayaFoiger AkshayaFoiger changed the title refactor: [Noon] add new field max_amount to mandate request #3481 refactor: [Noon] add new field max_amount to mandate request Feb 8, 2024
@AkshayaFoiger AkshayaFoiger self-assigned this Feb 8, 2024
@AkshayaFoiger AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Feb 8, 2024
@AkshayaFoiger AkshayaFoiger changed the title refactor: [Noon] add new field max_amount to mandate request refactor: [Noon] add new field max_amount to mandate request Feb 8, 2024
@likhinbopanna likhinbopanna merged commit 90812c7 into hotfix-2024.01.24.1 Feb 8, 2024
19 of 25 checks passed
@likhinbopanna likhinbopanna deleted the fix/noon-mandate-amount branch February 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] : Noon Api Contract Changes
4 participants