Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [NMI] Handle empty response in psync and error response in complete authorize #3550

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Handle empty response in psync and error response in complete authorize

main pr - #3548

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

test cases - Make payment, when status is in authentication_pending, make a psync, status should remain same
make a payment, after redirection , status should be succeeded.

successful payment -
Screenshot 2024-02-05 at 4 38 21 PM
Screenshot 2024-02-05 at 4 38 36 PM
Screenshot 2024-02-05 at 4 39 01 PM

payment having error code and message when the fields such as cavv, eci, xid
Screenshot 2024-02-05 at 3 35 43 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 5, 2024
@prasunna09 prasunna09 self-assigned this Feb 5, 2024
@prasunna09 prasunna09 requested review from a team as code owners February 5, 2024 11:37
@Gnanasundari24 Gnanasundari24 merged commit 781f024 into hotfix-2024.02.02.0 Feb 5, 2024
11 of 13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-nmi-psync branch February 5, 2024 12:55
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants