Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Trustpay] add merchant_id in gpay session response for trustpay #3532

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Feb 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add merchant_id in gpay session response for trustpay

PR merged in main - #3471

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

test cases - make a gpay payment for trustpay (in gpay session response, merchant_id should be present). testing of this pr can only be done in prod since this issue was only in prod.
Couldn't test in local.

tested in sbx - we received merchant_id
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 2, 2024
@prasunna09 prasunna09 self-assigned this Feb 2, 2024
@prasunna09 prasunna09 requested a review from a team as a code owner February 2, 2024 07:59
@likhinbopanna likhinbopanna merged commit 9b70a62 into hotfix-2024.01.24.1 Feb 2, 2024
14 of 17 checks passed
@likhinbopanna likhinbopanna deleted the fix-trustpay-gpay-session-resp branch February 2, 2024 09:40
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants