Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Add killswitch for blocklist feature #3459

Merged
merged 4 commits into from
Jan 25, 2024
Merged

refactor(core): Add killswitch for blocklist feature #3459

merged 4 commits into from
Jan 25, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will allow us to enable and disable the blocklist feature based on each merchant's requirements.
The steps to test out this feature can be found in the mentioned issue.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer R-waiting-on-L2 Review: Waiting on L2 reviewer labels Jan 25, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Jan 25, 2024
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner January 25, 2024 10:04
@prajjwalkumar17 prajjwalkumar17 linked an issue Jan 25, 2024 that may be closed by this pull request
[REFACTOR] Inclusion of kill switch in configs table #3443
Closed
@SanchithHegde SanchithHegde merged commit 8e9b3ac into hotfix-2024.01.24.1 Jan 25, 2024
10 of 13 checks passed
@SanchithHegde SanchithHegde deleted the hotfix_merchant_blocklist_enabled_config branch January 25, 2024 12:34
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer R-waiting-on-L2 Review: Waiting on L2 reviewer labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@tinu-hareesswar tinu-hareesswar tinu-hareesswar approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Inclusion of kill switch in configs table
4 participants
@prajjwalkumar17 @tinu-hareesswar @vspecky @SanchithHegde