Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytics): adding status code to connector Kafka events #3393

Merged
merged 7 commits into from
Jan 30, 2024
Merged

chore(analytics): adding status code to connector Kafka events #3393

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a46f4da
chore(analytics): adding status code to connector events
harsh-sharma-juspay Jan 18, 2024
699b256
chore: run formatter
hyperswitch-bot[bot] Jan 18, 2024
7cbd2b2
Merge branch 'main' into add_status_code_connector_events
harsh-sharma-juspay Jan 22, 2024
f4ee4ed
chore(lints): fix redundant clone
lsampras Jan 22, 2024
acc74d4
Merge branch 'main' into add_status_code_connector_events
lsampras Jan 24, 2024
e5a9b68
Merge branch 'main' into add_status_code_connector_events
harsh-sharma-juspay Jan 25, 2024
d45db57
Merge branch 'main' into add_status_code_connector_events
harsh-sharma-juspay Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/router/src/events/connector_api_logs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ pub struct ConnectorEvent {
created_at: i128,
request_id: String,
latency: u128,
status_code: u16,
}

impl ConnectorEvent {
Expand All @@ -33,6 +34,7 @@ impl ConnectorEvent {
merchant_id: String,
request_id: Option<&RequestId>,
latency: u128,
status_code: u16,
) -> Self {
Self {
connector_name,
Expand All @@ -52,6 +54,7 @@ impl ConnectorEvent {
.map(|i| i.as_hyphenated().to_string())
.unwrap_or("NO_REQUEST_ID".to_string()),
latency,
status_code,
}
}
}
Expand Down
9 changes: 8 additions & 1 deletion crates/router/src/services/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,13 @@ where
let response = call_connector_api(state, request).await;
let external_latency = current_time.elapsed().as_millis();
logger::debug!(connector_response=?response);

let status_code = response
.as_ref()
.map(|i| {
i.clone()
harsh-sharma-juspay marked this conversation as resolved.
Show resolved Hide resolved
.map_or_else(|value| value.status_code, |value| value.status_code)
})
.unwrap_or_default();
let connector_event = ConnectorEvent::new(
req.connector.clone(),
std::any::type_name::<T>(),
Expand All @@ -394,6 +400,7 @@ where
req.merchant_id.clone(),
state.request_id.as_ref(),
external_latency,
status_code,
);

match connector_event.try_into() {
Expand Down
Loading