Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(recon): update recipient email and mail body for ProFeatureRequest #3381

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Jan 18, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR corrects the recipient mail which notifies the HS team for any recon activation requests.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

How to test
Once deployed, request for recon activation using /recon/request API. Check the mail body sent to the recipient ([email protected])

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m requested a review from srujanchikke January 18, 2024 08:58
@kashif-m kashif-m self-assigned this Jan 18, 2024
@kashif-m kashif-m requested review from a team as code owners January 18, 2024 08:58
@kashif-m kashif-m changed the title refactor(recon): update recipient's email and mail body for ProFeatur… refactor(recon): update recipient's email and mail body for ProFeatureRequest Jan 18, 2024
srujanchikke
srujanchikke previously approved these changes Jan 18, 2024
srujanchikke
srujanchikke previously approved these changes Jan 18, 2024
@kashif-m kashif-m force-pushed the recon-recipient-update branch 2 times, most recently from f41bb34 to 8836ec0 Compare January 18, 2024 09:46
SanchithHegde
SanchithHegde previously approved these changes Jan 18, 2024
@kashif-m kashif-m added C-bug Category: Bug C-refactor Category: Refactor labels Jan 18, 2024
@kashif-m kashif-m linked an issue Jan 18, 2024 that may be closed by this pull request
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2024
@kashif-m kashif-m removed a link to an issue Jan 18, 2024
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 18, 2024
@likhinbopanna likhinbopanna removed this pull request from the merge queue due to a manual request Jan 18, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 18, 2024
@kashif-m kashif-m linked an issue Jan 18, 2024 that may be closed by this pull request
2 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2024
@kashif-m kashif-m force-pushed the recon-recipient-update branch from 0a4be5e to 9fbbe5e Compare January 18, 2024 13:10
@SanchithHegde SanchithHegde changed the title refactor(recon): update recipient's email and mail body for ProFeatureRequest refactor(recon): update recipient email and mail body for ProFeatureRequest Jan 18, 2024
@SanchithHegde SanchithHegde added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 5a791aa Jan 18, 2024
11 checks passed
@SanchithHegde SanchithHegde deleted the recon-recipient-update branch January 18, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Recon APIs
3 participants