-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pr-convention-checks): add job to check for linked issues for pull requests #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal commit check
… `pull_request_target` event for testing
SanchithHegde
added
A-CI-CD
Area: Continuous Integration/Deployment
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jan 17, 2024
…stead of `pull_request_target` event for testing This reverts commit f670eae.
SanchithHegde
requested review from
prajjwalkumar17,
pixincreate,
Chethan-rao and
ShankarSinghC
January 17, 2024 20:44
Chethan-rao
previously approved these changes
Jan 18, 2024
ShankarSinghC
previously approved these changes
Jan 18, 2024
… `pull_request_target` event for testing
SanchithHegde
dismissed stale reviews from ShankarSinghC and Chethan-rao
via
January 18, 2024 12:21
98dc2fd
…stead of `pull_request_target` event for testing This reverts commit 98dc2fd.
ShankarSinghC
approved these changes
Jan 18, 2024
Chethan-rao
approved these changes
Jan 18, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds a new pull request CI check to ensure that all pull requests have at least one linked issue.
However, GitHub does not send any webhooks when a pull request is linked with an issue, so the check does not get triggered automatically when an issue is linked for a pull request which is already open. One way to trigger it manually is to update either the pull request title or description/body, and another is to push commits. Since pushing new commits tends to trigger all other checks, editing the pull request description might be preferable in such scenarios.
In addition, the PR includes the following changes:
conventional-commit-check.yml
workflow file topr-convention-checks.yml
.The pull request can be reviewed one commit at a time for better understanding.
Motivation and Context
Closes #3375.
How did you test it?
Temporarily modified the trigger to be
pull_request
instead ofpull_request_target
to test the workflow.The check fails if the PR does not contain any linked issues.
Link to check run: https://github.com/juspay/hyperswitch/actions/runs/7561263548/job/20589130650?pr=3376
The check succeeds if the PR contains at least one linked issue.
Link to check run: https://github.com/juspay/hyperswitch/actions/runs/7561509816/job/20589902417?pr=3376
The check fails if any of the linked issues is closed.
Checklist
cargo +nightly fmt --all
cargo clippy