Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): send metadata in payment authorize request for noon nmi cryptopay #3325

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Jan 11, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Send metadata in the authorize request for noon, nmi and cryptopay.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual.

  1. CryptoPay (connector force sync response)
Cryptopay log
  1. NMI (connector force sync response)
    Authomatic capture (auth+capture)
Screenshot 2024-02-06 at 12 36 19 PM

Manual Capture(auth and then capture)
Screenshot 2024-02-06 at 1 16 28 PM

  1. Noon (connector dashboard)
Screenshot 2024-01-31 at 8 25 10 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 11, 2024
@hrithikesh026 hrithikesh026 self-assigned this Jan 11, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner January 11, 2024 09:59
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner February 5, 2024 12:11
@ArjunKarthik
Copy link
Contributor

@hrithikesh026 For each connector please add test case for Manual capture, void, where metadata passed in Authorize flow should be visible in all the transaction (Authorize, Capture, Void) in the connector dashboard.

@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit ebe4ac3 Feb 6, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the noon-cryptopay-nmi-metadata-mapping branch February 6, 2024 13:48
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] send metadata field in authentication request for nmi, noon and cryptopay
5 participants