-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [BOA/Cyb] Include merchant metadata in capture and void requests #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
labels
Jan 10, 2024
2 tasks
Narayanbhat166
previously approved these changes
Jan 10, 2024
ArjunKarthik
previously approved these changes
Jan 10, 2024
Narayanbhat166
previously approved these changes
Jan 11, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
deepanshu-iiitu
dismissed stale reviews from Narayanbhat166 and ArjunKarthik
via
January 11, 2024 10:08
c16dcf8
deepanshu-iiitu
requested review from
ArjunKarthik,
Narayanbhat166 and
vspecky
January 11, 2024 10:08
Narayanbhat166
approved these changes
Jan 11, 2024
vspecky
approved these changes
Jan 11, 2024
vspecky
approved these changes
Jan 11, 2024
SanchithHegde
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Original PR: #3308
Include merchant metadata in capture and void requests for connectors BOA and Cybersource.
Note: This PR only contains the fix for BOA because Cybersource Metadata changes are not present in this version.
Additional Changes
Motivation and Context
#3307
How did you test it?
Testing can be done by creating 2 manual authorized payments for Bankofamerica. While creating these payments you should pass metadata in the requests.
Then you should void one payment and capture the other. You should then be able to see this metadata in merchantDefinedInformation in BOA Dashboard.
Checklist
cargo +nightly fmt --all
cargo clippy